Fossil

Check-in [6c8cec73]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Add the --localhost argument to the fossil server command invoked by test_start_server in test/tester.tcl. This change causes the server to only bind to localhost:8080, which does not trigger the Windows Firewall to panic about a program attempting to communicate with the world. Tested on a 64-bit binary built from VS2010, and a 32-bit binaray build from MinGW GCC 4.2.7, both under Windows 10 Pro. I expect the flag works and is harmless on other platforms.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1:6c8cec734114b5ce451e6ec1e79191f1353f3744
User & Date: rberteig 2016-10-14 22:49:03
Context
2016-10-15
04:56
Further revise the 'test_start_server' and 'test_stop_server' test suite helper procedures to make it possible to actually delete the temporary output-capture file on Windows. check-in: b0081d97 user: mistachkin tags: trunk
2016-10-14
22:49
Add the --localhost argument to the fossil server command invoked by test_start_server in test/tester.tcl. This change causes the server to only bind to localhost:8080, which does not trigger the Windows Firewall to panic about a program attempting to communicate with the world. Tested on a 64-bit binary built from VS2010, and a 32-bit binaray build from MinGW GCC 4.2.7, both under Windows 10 Pro. I expect the flag works and is harmless on other platforms. check-in: 6c8cec73 user: rberteig tags: trunk
20:34
Merge fork check-in: 3a35ac58 user: andygoth tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to test/tester.tcl.

753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
# This procedure executes the "fossil server" command.  The return value
# is a list comprised of the new process identifier and the port on which
# the server started.  The varName argument refers to a variable
# where the "stop argument" is to be stored.  This value must eventually be
# passed to the [test_stop_server] procedure.
proc test_start_server { repository {varName ""} } {
  global fossilexe tempPath
  set command [list exec $fossilexe server]
  if {[string length $varName] > 0} {
    upvar 1 $varName stopArg
  }
  if {$::tcl_platform(platform) eq "windows"} {
    set stopArg [file join [getTemporaryPath] [appendArgs \
        [string trim [clock seconds] -] _ [getSeqNo] .stopper]]
    lappend command --stopper $stopArg







|







753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
# This procedure executes the "fossil server" command.  The return value
# is a list comprised of the new process identifier and the port on which
# the server started.  The varName argument refers to a variable
# where the "stop argument" is to be stored.  This value must eventually be
# passed to the [test_stop_server] procedure.
proc test_start_server { repository {varName ""} } {
  global fossilexe tempPath
  set command [list exec $fossilexe server --localhost]
  if {[string length $varName] > 0} {
    upvar 1 $varName stopArg
  }
  if {$::tcl_platform(platform) eq "windows"} {
    set stopArg [file join [getTemporaryPath] [appendArgs \
        [string trim [clock seconds] -] _ [getSeqNo] .stopper]]
    lappend command --stopper $stopArg