Hello all,

The "Copy Ticket" and "Edit Wiki" hyperlinks on the /tktview/ page do not follow --baseurl. This results in a broken link if the repository is not hosted at the root of the URL.

Minimum working example (MWE) showing the bug:

$ echo 'GET /tktview/f0a4cdc791 HTTP/1.1' | env REMOTE_ADDR=127.0.0.1 fossil http ~/fossils/fossil.fossil --localauth --baseurl http://127.0.0.1/feliznavidad | grep -E "(Copy Ticket|Edit Wiki)" 
<a class="label sml-copy-ticket" href="/tktnew/f0a4cdc7915a946edd18b22b5451dd2b2e4dc5cc">Copy Ticket</a>
<a class="label sml-edit-wiki" href="/wikiedit?name=ticket/f0a4cdc7915a946edd18b22b5451dd2b2e4dc5cc">Edit Wiki</a>

After patching:

$ echo 'GET /tktview/f0a4cdc791 HTTP/1.1' | env REMOTE_ADDR=127.0.0.1 ./fossil http ~/fossils/fossil.fossil --localauth --baseurl http://127.0.0.1/feliznavidad | grep -E "(Copy Ticket|Edit Wiki)" 
<a class="label sml-copy-ticket" href="http://127.0.0.1/feliznavidad/tktnew/f0a4cdc7915a946edd18b22b5451dd2b2e4dc5cc">Copy Ticket</a>
<a class="label sml-edit-wiki" href="http://127.0.0.1/feliznavidad/wikiedit?name=ticket/f0a4cdc7915a946edd18b22b5451dd2b2e4dc5cc">Edit Wiki</a>

Here is the patch I applied:

Index: src/tktsetup.c
==================================================================
--- src/tktsetup.c
+++ src/tktsetup.c
@@ -494,14 +494,14 @@
 @     html "<td class='tktDspValue' colspan='3'>Deleted</td></tr>\n"
 @   }
 @ }
 @
 @ if {[capexpr {n}]} {
-@   submenu link "Copy Ticket" /tktnew/$tkt_uuid
+@   submenu link "Copy Ticket" $baseurl/tktnew/$tkt_uuid
 @ }
 @ if {[capexpr {nk}]} {
-@   submenu link "Edit Wiki" /wikiedit?name=ticket/$tkt_uuid
+@   submenu link "Edit Wiki" $baseurl/wikiedit?name=ticket/$tkt_uuid
 @ }
 @ </th1>
 @ <tr><td class="tktDspLabel">Title:</td>
 @ <td class="tktDspValue" colspan="3">
 @ $<title>

license: public domain / https://creativecommons.org/public-domain/cc0/