Fossil Forum

Technotes without timeline comments cause cli segfault
Login

Technotes without timeline comments cause cli segfault

Technotes without timeline comments cause cli segfault

(1) By anonymous on 2022-08-10 06:30:21 [source]

reproduce with 2.19 1e131febd3:

  1. (cli) fossil init example.fossil
  2. (cli) fossil open example.fossil
  3. (cli) fossil ui
  4. (web) browse to /technotedit
  5. (web) fill in page content, ignoring other fields, hit preview, then submit
  6. confirm segfaults
    • (web) try displaying the timeline in different ways (they all seem to work)
    • (cli) fossil timeline # this works
    • (cli) fossil timeline --oneline # segfault
    • (cli) fossil timeline --medium # segfault
    • (cli) fossil timeline --full # segfault

If you add other technotes after this that have timeline comments, the commands will segfault after displaying those, when they reach the comment-less tech note: for example with a comment of 'commented':

$ fossil timeline --oneline
22830d6891 commented
Segmentation fault (core dumped)

While I'm here I should that I really like technotes as a temporal alternative to the wiki, and not just for their intended purpose, and I only have minor complaints:

  1. I have to delete "Insert new content here..." all the time before typing. I'd prefer this to be placeholder="text"
  2. full text search, even when enabled for technotes, doesn't see tags or timeline comments
  3. in the web ui, clicking a tech notes's tags won't show other tech notes with the same tag

(2) By Stephan Beal (stephan) on 2022-08-10 07:01:00 in reply to 1 [link] [source]

Segmentation fault (core dumped)

i will look into this ASAP but it may take me until tomorrow. Thank you for the repro steps.

I have to delete "Insert new content here..." all the time before typing. I'd prefer this to be placeholder="text"

The technote UI predates when that HTML feature was standardized and few of us use technotes with any frequency, so it's never bothered anyone enough to update it. i will do so "soon," but my plate is currently full so it may be a few days or even a week.

Sidebar: ideally the technotes could be migrated into the wiki editor but it's never been done because technotes have kind of fallen to the wayside.

full text search, even when enabled for technotes, doesn't see tags or timeline comments

i can't say anything about that off hand (never touched the FTS bits) but will look into it.

in the web ui, clicking a tech notes's tags won't show other tech notes with the same tag

That's a new feature which requires someone whose itched enough by the problem to add a non-trivial amount of code for. Though that could ostensibly be me, i simply cannot commit (haha) to that right now - other priorities currently trump my work on all non-trivial/non-critical/non-crash fixes.

In any case, thank you for your report and i'll flag this email so i don't forget it or delete it before the crash and placeholder bits are resolved and the FTS has been looked at (possibly resolved, depending on whether it needs significant new code).

(3) By Stephan Beal (stephan) on 2022-08-14 20:08:52 in reply to 1 [link] [source]

confirm segfaults

That's now resolved in the trunk, in that it ouputs "(NULL)" instead of crashing or skipping that entry. That label was taken from a similar case in another part of the tree. Thank you again for the detailed reproduction steps.

I have to delete "Insert new content here..." all the time before typing. I'd prefer this to be placeholder="text"

Resolving that is currently more invasive than it should be, requiring a several new is-NULL checks and an extra internal flag to keep track of whether or not the page had a genuine body, so i'm going to punt on that problem for now and leave it as is. Conflicting time priorities currently keep me from diving into new rabbit holes.

full text search, even when enabled for technotes, doesn't see tags or timeline comments

Insofar as i can tell it never has, so will also punt on that problem for the same reasons as above. The tag-related search feature doesn't use the FTS and the timeline is hard-coded to search only checkins when tags are searched. Extending that is another rabbit hole i can't currently go down, but anyone interested in doing so should look here.