Forum thread listing under Dark mode

(1.3) Originally by brickviking with edits by Stephan Beal (stephan) on 2023-04-19 00:28:16 from 1.2 [source]

Hi again. I've got a question relating to the forum thread listing. With the darkmode skin, visited threads aren't visually distinct from unvisited threads, yet with the default skin, they're quite distinct.

I use the "visited vs. unvisited" to tell if (a) I've read a thread, or (b) it's got new content that I haven't caught up with yet, and it'd be nice if the visited threads were distinct from the unvisited threads on dark mode as they are on the default skin and some other light skins.

I took a quick look at the relevant CSS file, and I've prepared a patch for the darkmode skin I thought might be useful for separating out the visited threads from the unvisited threads.

--- a/skins/darkmode/css.txt	2022-11-25 01:40:29.857265925 +1300
+++ b/skins/darkmode/css.txt	2023-03-15 02:17:53.739072067 +1300
@@ -563,6 +563,13 @@
     color: rgba(24,24,24,0.8);
 }
 
+body.forum .fileage a:visited {
+   color: rgba(98, 150, 205, 0.9);
+   display: inline;
+   text-decoration: none;
+   opacity: 0.8;
+}
+
 body.forum .forumPostBody > div blockquote {
     border: 1px inset;
     padding: 0 0.5em;

I also checked the instructions for creating a new skin, and I think there's a mistake in step 3.

--- a/skins/README.md	2022-11-25 01:40:29.834265762 +1300
+++ b/skins/README.md	2023-03-15 00:46:49.476715739 +1300
@@ -23,7 +23,7 @@
         skins/newskin/footer.txt, skins/newskin/header.txt, and
         skins/newskin/js.txt. Be sure to "fossil add" these files.
 
-   3.   Go to the src/ directory and rerun "tclsh makemake.tcl".  This
+   3.   Go to the tools/ directory and rerun "tclsh makemake.tcl".  This
         step rebuilds the various makefiles so that they have dependencies
         on the skin files you just installed.

I hope these help out.

Cheers, brickviking

(Post 12)

(2) By Stephan Beal (stephan) on 2023-03-14 14:19:38 in reply to 1.0 [link] [source]

I took a quick look at the relevant CSS file, and I've prepared a patch for the darkmode skin I thought might be useful for separating out the visited threads from the unvisited threads.

This slight variation of your patch was just checked in:

+body.forum .forumPosts.fileage a:visited {
+  color: rgba(98, 150, 205, 0.9);
+}

the other 3 style aspects you suggest are inherited from other rules so don't need to be made explicit.

That change will take effect the next time Richard updates this server's fossil binary.

The src/tools directory fix was also checked in - that typo was left over from tree reorganization we did a year or so ago.

(3.1) By brickviking on 2023-03-14 21:29:08 edited from 3.0 in reply to 2 [link] [source]

Looks great. Thank you for that. As I said, I'm not au fait with how CSS selectors work. I don't think I ever really made the transition from table-based HTML. I might take a look at the other dark-mode skins and see what changes I can make there, though I'm well aware that there's probably a few people that worked on all those.

Cheers, brickviking

(Post 13)