Fossil Forum

RFC: Eagle skin logo link
Login

RFC: Eagle skin logo link

RFC: Eagle skin logo link

(1) By Stephan Beal (stephan) on 2021-09-15 04:11:17 [source]

Today i just kind of randomly ended up in Fossil's "Eagle" skin and did some minor cleanup. One thing which sticks out is how it links the logo image in the top left: it specifically goes out of its way to point to the top of the domain, rather than the top of the fossil repo. While that might (not sure) make sense for some very few sites, it seems less so for the average repository, where the logo "should" (arguably) link back to the top of the repo.

Would anyone here who makes use of that skin object to my linking the logo to the top of the current repo, as opposed to the very top of the domain? (Noting, of course, that that would become the default for future users of that skin unless they specifically edit it to re-add the legacy behaviour.)

As an example:

https://fossil.wanderinghorse.net/r/libfossil/timeline?skin=eagle

clicking the logo there will currently take the user back to https://fossil.wanderinghorse.net instead of to the top of the current repo.

That seems like a bug, or at least a very minority-case option, to me.

:-?

(2) By John Rouillard (rouilj) on 2021-09-15 18:00:00 in reply to 1 [link] [source]

I use a modified version of eagle and yeah I thought it was a bug.

(3) By mistachkin on 2021-09-15 20:02:53 in reply to 1 [link] [source]

Actually, it was intentional. Because there is already the "Home" link and I wanted a link to the main site.

(4) By Stephan Beal (stephan) on 2021-09-15 22:26:23 in reply to 3 [link] [source]

Because there is already the "Home" link and I wanted a link to the main site.

Is it still being used that way? The current behaviour will take a user, e.g., from this forum over to the main repo (via /, then an extra direct to /home), which seems confusing and counter-intuitive.

i'll add an if block around that bit so that the mode can be toggled, and your answer will determine the default for the toggle ("yes" = "domain mode", "no" = "repo mode").

(5) By mistachkin on 2021-09-16 13:47:16 in reply to 4 [link] [source]

Yes, it's still being used that way. I like your "if block" idea, although I'm a bit fuzzy on how it will work. Looking forward to seeing it.

(6) By Stephan Beal (stephan) on 2021-09-16 15:41:57 in reply to 5 [link] [source]

I like your "if block" idea, although I'm a bit fuzzy on how it will work. Looking forward to seeing it.

Here you go: c4c64257cf2c4e14

(7) By mistachkin on 2021-09-16 17:35:36 in reply to 6 [link] [source]

Very nice. I guess that's simple... :)

(8) By matt w. (maphew) on 2021-09-17 02:43:23 in reply to 1 [link] [source]

My personal preference is for the left most link-thing, be it a logo, text or some other visual element, go to the top of the domain. It's friction to have to go to the url bar and edit in order to navigate out of the subsite one is currently in. I have to do this every day at work in Sharepoint and it's annoying. That said, I don't use the Eagle skin, so {shrug}. ;-)