Fossil

Check-in [3bcdc077]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Rework [98cc8782e1] to more thoroughly ignore empty match tags and patterns so that the "Related" submenu item does not appear due to an empty tag filter text entry adding "t=" to the query string
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | andygoth-timeline-ms
Files: files | file ages | folders
SHA1: 3bcdc0779382af51e9c8e3be74dcceda58924e34
User & Date: andygoth 2016-11-05 03:42:02
Context
2016-11-05
05:15
Add functions to modify and delete query parameters check-in: 1c511cd9 user: andygoth tags: andygoth-timeline-ms
03:42
Rework [98cc8782e1] to more thoroughly ignore empty match tags and patterns so that the "Related" submenu item does not appear due to an empty tag filter text entry adding "t=" to the query string check-in: 3bcdc077 user: andygoth tags: andygoth-timeline-ms
03:34
Merge trunk. Some issues identified by [d4a6d3c1ec] are now improved. (1) is fixed, though clicking/tabbing outside the entry field also triggers a submit which may prove annoying. (2) and (3) are still broken. (4) is better because "With/Without Files" is now a checkbox simply labeled "Files". (5) is closer to being feasible, perhaps if "Tag Filter:" is changed to "Filter:". check-in: 74fe9587 user: andygoth tags: andygoth-timeline-ms
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to src/timeline.c.

1526
1527
1528
1529
1530
1531
1532
1533








1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
   || (bisectOnly && !g.perm.Setup)
  ){
    login_needed(g.anon.Read && g.anon.RdTkt && g.anon.RdWiki);
    return;
  }
  url_initialize(&url, "timeline");
  cgi_query_parameters_to_url(&url);









  /* Identify the tag or branch name or match pattern. */
  if( zTagName && *zTagName ){
    zThisTag = zTagName;
  }else if( zBrName && *zBrName ){
    zThisTag = zBrName;
  }

  /* Interpet the tag style string. */
  if( zThisTag ){
    if( fossil_stricmp(zMatchStyle, "glob")==0 ){
      matchStyle = MS_GLOB;








>
>
>
>
>
>
>
>

|

|







1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
   || (bisectOnly && !g.perm.Setup)
  ){
    login_needed(g.anon.Read && g.anon.RdTkt && g.anon.RdWiki);
    return;
  }
  url_initialize(&url, "timeline");
  cgi_query_parameters_to_url(&url);

  /* Ignore empty tag or branch name query strings. */
  if( zTagName && !*zTagName ){
     zTagName = 0;
  }
  if( zBrName && !*zBrName ){
     zBrName = 0;
  }

  /* Identify the tag or branch name or match pattern. */
  if( zTagName ){
    zThisTag = zTagName;
  }else if( zBrName ){
    zThisTag = zBrName;
  }

  /* Interpet the tag style string. */
  if( zThisTag ){
    if( fossil_stricmp(zMatchStyle, "glob")==0 ){
      matchStyle = MS_GLOB;