Fossil

Check-in [5358fe95]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Removed the "Linux" platform test from the DNS MX stuff in src/smtp.c. You should always test for features, not platforms, and we've now got the feature tests we need to replace this too-broad platform test.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | libbind-ns-alternative
Files: files | file ages | folders
SHA3-256: 5358fe9563bf2aa6815b46c8aa597b61274c615657b52e2cb0cb276be061f8a0
User & Date: wyoung 2018-09-22 16:55:39
Context
2018-09-22
17:02
Added a check for ns_parserr(), which we currently don't know how to find on OpenBSD. This also fixes a logic error in auto.def which would cause the warning that this feature won't be compiled to not be given. check-in: f99e7632 user: wyoung tags: libbind-ns-alternative
16:55
Removed the "Linux" platform test from the DNS MX stuff in src/smtp.c. You should always test for features, not platforms, and we've now got the feature tests we need to replace this too-broad platform test. check-in: 5358fe95 user: wyoung tags: libbind-ns-alternative
16:38
Replaced the call to the undocumented ns_name_uncompress() function with dn_expand(), which is documented, at least on OpenBSD, and it's shorter. Then made ns_name_uncompress() and __ns_name_uncompress() fallbacks for this, with suitable autosetup tests for all of it. check-in: d0fb5ac7 user: wyoung tags: libbind-ns-alternative
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to src/smtp.c.

    17     17   **
    18     18   ** Implementation of SMTP (Simple Mail Transport Protocol) according
    19     19   ** to RFC 5321.
    20     20   */
    21     21   #include "config.h"
    22     22   #include "smtp.h"
    23     23   #include <assert.h>
    24         -#if HAVE_DN_EXPAND || HAVE___NS_NAME_UNCOMPRESS || HAVE_NS_NAME_UNCOMPRES || \
    25         -    (defined(__linux__) && !defined(FOSSIL_OMIT_DNS))
           24  +#if (HAVE_DN_EXPAND || HAVE___NS_NAME_UNCOMPRESS || HAVE_NS_NAME_UNCOMPRES) && \
           25  +    !defined(FOSSIL_OMIT_DNS)
    26     26   #  include <sys/types.h>
    27     27   #  include <netinet/in.h>
    28     28   #  if defined(HAVE_BIND_RESOLV_H)
    29     29   #    include <bind/resolv.h>
    30     30   #    include <bind/arpa/nameser_compat.h>
    31     31   #  else
    32     32   #    include <arpa/nameser.h>