Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
45 events by user mark occurring around 2022-01-20 08:54:29.
|
2024-09-23
| ||
| 10:43 | include limits.h header for LONG_MAX on darwin While here, change buf->cursor precondition comparison check to ensure it is not greater than buf->used. It may be an unreachable state but we must guard it nonetheless. And expand getdelim() regress by covering the empty or end-of-buffer precondition path, and the no matching delimiter found in the stream path. check-in: 322452cb8b user: mark tags: trunk | |
|
2024-09-22
| ||
| 15:38 | implement fsl_buffer_get{delim,line}() and regress test This API provides the same semantics as POSIX.1-2024 getdelim(3), which the fsl_buffer structure conveniently facilitates. A new regress test case is also added to f-sanity. Briefly discussed in /chat with Stephan. https://pubs.opengroup.org/onlinepubs/9799919799/functions/getdelim.html check-in: efb25dec6f user: mark tags: trunk | |
|
2024-09-21
| ||
| 01:27 | zap deadstore via missing break statement in switch block I suspect this fallthrough attribute was incorrectly added to silence a compiler warning that was in this case warranted. We don't want to clobber c; `c = offset` is correct for SEEK_SET. Incidentally, this routine's regress test was not failing the SEEK_SET case[0] because bin->cursor is at 0 so the fallthrough to the SEEK_CUR case[1] equates to `c = 0 + offset`. As such this commit also reorders test cases for a more rigorous regresssion test of fsl_buffer_seek(). [0]: assert(0==fsl_buffer_seek(&bin, 0, FSL_BUFFER_SEEK_SET)); [1]: case FSL_BUFFER_SEEK_CUR: c = (int64_t)b->cursor + offset; break; check-in: 5d2f636c0c user: mark tags: trunk | |
|
2024-09-15
| ||
| 11:25 | • Reply: Another tiny patch for Linux GNUmakefile.in artifact: 3e556e870e user: mark | |
| 11:11 | latest upstream fnc [fnc:26adf1707c] check-in: 8e0da47996 user: mark tags: trunk | |
| 10:53 | • Reply: Another tiny patch for Linux GNUmakefile.in artifact: cbb26336b4 user: mark | |
|
2024-09-14
| ||
| 11:24 | • Reply: Another tiny patch for Linux GNUmakefile.in artifact: cba6bd5405 user: mark | |
|
2024-09-13
| ||
| 10:49 | • Reply: Tiny patch for Linux (brickviking) artifact: 00e29043aa user: mark | |
|
2023-11-23
| ||
| 13:07 | fix 'f-delta -a' cli option clobbering so that the delta in arg1 actually gets applied to the file in arg2 and the result written to stdout rather than outputting the delta between arg1 and arg2 as we do when no option is passed to 'f-delta' check-in: 72f05d4c41 user: mark tags: trunk | |
| 12:49 | fix rejection of zero-length deltas to make delta creation and application consistent with fossil(1) check-in: cd5b50685b user: mark tags: trunk | |
|
2023-11-22
| ||
| 11:54 | s/__unused/fsl__unused as discussed in /chat with stephan@ to help avoid name collisions with package maintainers; no functional change intended check-in: 230cf225fc user: mark tags: trunk | |
|
2022-11-24
| ||
| 13:51 | add FCLI_RC_NO_CMD result code for fcli_dispatch_commands() To help distinguish between invalid commands and propagated FSL_RC_NOT_FOUND errors returned from successfully dispatched commands. ok stephan@ check-in: 46008704a6 user: mark tags: trunk | |
| 13:49 | make fcli_cmd_aliascmp() return semantics match convention Return 0 if a match is found as one would expect from a *_cmp() routine. ok stephan@ check-in: 6e0d1fbc09 user: mark tags: trunk | |
|
2022-11-21
| ||
| 03:30 | squelch gcc-11.2.0 uninitialised variable warning If fsl_buffer_cstr2() errors out, nOrig isn't initialised. ok stephan@ check-in: ef78842aea user: mark tags: trunk | |
|
2022-11-20
| ||
| 12:20 | ensure dstsz-1 is greater than the current length of dst Although somewhat contrived it's a potential problem nonetheless: if the caller passes a destination buffer that contains a string greater than the passed in size of the destination buffer (which is senseless at it means the buffer is already overflowed), we write the full length of src, which could overflow dst. This change makes our fsl_strlcat() implementation behave the same as OpenBSD's strlcat(3) in testing. check-in: f2676cbcc2 user: mark tags: trunk | |
|
2022-06-09
| ||
| 04:10 | Set transient helpRequested flag in the fcli singleton. If the client has requested help (cf. [/file?ci=tip&name=src/cli.c&ln=966]) with, for example. 'prog cmd help' set this flag. check-in: 6e9726df51 user: mark tags: trunk | |
|
2022-02-15
| ||
| 14:46 | As per Stephan's suggestion in /chat, pluralise ignoreRid(s). check-in: 36b2799c8e user: mark tags: dev-blame-ignore | |
| 14:33 | Enable ignoring specific commits when annotating file. Add flag to annotate options struct to ignore all merge commits. Similarly, provide array to assign rid values of specific versions to ignore specified commits. If either are set, any changed lines from the ignored version(s) will be annotated from the previous commit in the file history. check-in: 79fd090adb user: mark tags: dev-blame-ignore | |
|
2022-02-04
| ||
| 14:22 | Initial port of Fossil's files-of-checkin (foci) vtable. First pass of porting fossil(1) src/foci.c to libfossil; it's pretty much a 1:1 port using libf's ADTs. This builds, but the implementation isn't used anywhere so that's not a surprise. There is no test yet either, so branching this for further review. check-in: 677d51061d user: mark tags: wip-foci | |
|
2022-01-20
| ||
| 09:38 | Replace calls to the deprecated fsl_ckout_close(f) routine. Replace with fsl_close_scm_dbs(f). check-in: f876a65bef user: mark tags: trunk | |
| 08:54 | Remove deprecated diff v1 code as per /chat discussion. This removes all exclusive diff v1 library routines and data types in preparation for importing this implementation into fnc as per chat with Stephan. It is on a branch pending review in case any bits were missed or incorrectly purged. Closed-Leaf check-in: dbf0fb30dd user: mark tags: rm-diff-v1 | |
|
2021-12-15
| ||
| 13:49 | Bump _XOPEN_SOURCE from 500 to 700 for macOS builds. unistd.h functions readlink() and symlink() require _POSIX_C_SOURCE >= 200112L, which _XOPEN_SOURCE 700 provides. No noticeable impact on OpenBSD or Linux. check-in: 7c8cbd723a user: mark tags: trunk | |
|
2021-11-30
| ||
| 16:35 | Fix bug in annotate logic when file has insufficient history. When the file being annotated has less than the minimum three versions, one of the passes returns a null from the SQL query, which gets falsely reported as an OOM due to an empty strdup(). Check for this case before passing to strdup() and return. check-in: 11a6a98c81 user: mark tags: trunk | |
|
2021-11-29
| ||
| 15:06 | Don't drop and create fsl_compute_ancestors if it already exists. To workaround some locking issues in fnc, don't always drop and recreate the temp fsl_compute_ancestors table; instead, check for existence and only create when needed. Also, as per /chat discussion with stephan@, if the table exists, DELETE FROM to ensure we don't mix state between versions. check-in: 009bc1ff55 user: mark tags: trunk | |
| 06:52 | Fix comparison typo that clobbered requested version. The fsl_card_F_ckout_mtime() doc suggests that the current checkout will only be used if the rid of the passed in version is 0; however, the typo forced all rids greater than or equal to 0 to be overridden with the checkout version. check-in: 0031d2f466 user: mark tags: trunk | |
|
2021-11-21
| ||
| 04:26 | Remove dated comment from the annotate API options doc. stephan@ implemented the timer-based limit option to the annotate operation in [35b8297bc34b]. check-in: 70ee710a3d user: mark tags: trunk | |
|
2021-11-01
| ||
| 15:58 | Add fsl_strlcpy() and fsl_strlcat() BSD-variants to the lib. Less error prone routines to begin replacing strcpy() and strcat() calls. check-in: f390a48d56 user: mark tags: trunk | |
| 15:16 | Add ifdefs for C99 decls (snprintf) guarded on macOS. Patch authored by stephan@, tested by mark@ on macOS Catalina 10.15.7. check-in: 5c54c1e93c user: mark tags: trunk | |
|
2021-10-29
| ||
| 10:36 | Add optional usage callback to fcli_command structure. If set, calls to fcli_command_help() with a true argument for the showUsage parameter, will call the fcli_command->usage() callback. This enables clients to display usage and/or additional help output on an individual command basis. Update apps in the repository impacted by this API change. check-in: d60fcce917 user: mark tags: trunk | |
| 10:15 | Latest upstream fnc with several major changes. This fnc update includes: a significant change to the diff interface, which offers improved arg parsing and the ability to diff file blobs; and the new 'fnc branch' command, which provides a view for navigating repository branches. check-in: b1c9f30e3f user: mark tags: trunk | |
|
2021-10-22
| ||
| 06:01 | Tidy fcli_command->aliases code and improve related docs. Remove superfluous format specifier arg and move all aliases output into fcli_help_show_aliases(). check-in: 89925fee94 user: mark tags: trunk | |
|
2021-10-21
| ||
| 14:54 | Integrate [d9d00a5c97|cli-aliases] into trunk. ok stephan@ check-in: 378813076a user: mark tags: trunk | |
| 14:32 | Add optional command line aliases to fcli_command. As per /chat discussion, use a NUL-delimited char pointer to add optional aliases to a command. This commit also adapts fcli_command_help() output to display any aliases, and adapts fnc and existing f-apps that use fcli_command to demonstrate the change. Closed-Leaf check-in: d9d00a5c97 user: mark tags: cli-aliases | |
|
2021-10-07
| ||
| 03:28 | Remove all but -R and -V short form global options. To avoid collisions with app code, restrict global options to long-form, with the exception of the abovementioned two common options as discussed in /chat. check-in: 6d2c463307 user: mark tags: trunk | |
|
2021-10-06
| ||
| 16:07 | Add a few errno error codes to fsl_errno_to_rc(). check-in: 12ce7c1243 user: mark tags: trunk | |
|
2021-10-01
| ||
| 16:31 | Minor fixes to address gcc-11 errors discussed in chat. Check a set but unused variable in the new diff implementation, and fix arguments with mismatched bound in the md5 code. check-in: a161c58256 user: mark tags: trunk | |
|
2021-09-02
| ||
| 18:02 | Latest upstream changes from fnc. Includes a screen-rendering bug fix, and improved error handling/reporting in the multibyte to wide-char conversion. check-in: ce9e0fcfd0 user: mark tags: trunk | |
|
2021-08-24
| ||
| 17:12 | Enhance repo fingerprint check to cover old repositories. This commit adds an extra check to match repository fingerprints using the original algorithm that some old repositories in the wild may need. check-in: 043c2667c9 user: mark tags: trunk | |
| 13:31 | Build fix for the amalgamation build on macOS. The new amalgamation build requires lib iconv on macOS. check-in: ee5b0675a1 user: mark tags: trunk | |
|
2021-03-07
| ||
| 10:57 | • Reply: Milestone: first-ever libfossil-opened repository artifact: 55b37598ff user: mark | |
|
2021-03-02
| ||
| 08:49 | Implement f-open and f-checkout roughly ported from db.c::cmd_open() and checkout.c::checkout_cmd() in Fossil using a draft implementation of the fsl_repo_open_checkout API designed by Stephan. This is a work in progress and is missing a few critical pieces but will open and checkout a given repository. Only tested on OpenBSD and macOS and may not work on Windows yet. check-in: 4897fa7285 user: mark tags: open-ckout-wip | |
|
2021-02-27
| ||
| 04:21 | Remove unneeded error check for fsl_buffer_reset() as it's infallible in this call. check-in: 46bbae2d88 user: mark tags: trunk | |
|
2021-02-26
| ||
| 14:39 | Fix bug that unnecessarily resizes buffer resulting in incorrect b->used for SHA3 hash length checks. check-in: 5c04ab3a23 user: mark tags: trunk | |
|
2021-02-12
| ||
| 04:37 | Fix 'uninitialized use' of rc variable when default switch is hit. check-in: 32d545fd62 user: mark tags: trunk | |
|
2021-02-10
| ||
| 13:51 | Amend make config files to generate compilation database. Add MAKE_COMPILATION_DB variable to enable the '-MJ' flag on supported compilers to generate a compile_commands.json compilation database. Closed-Leaf check-in: b9be211162 user: mark tags: make-compdb | |