Fossil User Forum

Fixes for a couple of cosmetic issues
Login

Fixes for a couple of cosmetic issues

Fixes for a couple of cosmetic issues

(1) By graham on 2020-05-28 13:19:11 [source]

While working on a possible implementation of viewing uncommitted changes in Fossil's UI (see this thread), I spotted a couple of minor cosmetic issues:

  1. If you go to a file's history page (e.g. from the "Modified src/fileedit.c..." link on a check-in page) and click on the base filename in "History for src/fileedit.c the title shows as "fileedit.c at []". The problem seems to be that when "ci" isn't specified (the URL is "/home/file?name=src/fileedit.c"), and defaults to "tip", it isn't marked as isSymbolicCI. Check-in 551676bc on the ui-local-diff branch shows the title as "fileedit.c at tip", the same as when "&ci=tip" is appended to the URL.

  2. On a check-in page, if you switch to the non-default side-by-side/unified option, and then toggle the show/ignore whitespace option, it reverts to the default display style. Check-in e6ab947e on the same branch fixes this by passing through the current diffType setting (as the SBS/Unified links do for the current whitespace setting). (Of course, it could be meant to work this way, in which case I apologize, but it feels wrong to me).

Unless someone asks me not to, I'll probably be pushing my initial implementation of viewing uncommitted changes in the current checkout today or tomorrow, but I thought I'd push these two first: at least they can be cherry-picked even if the "local diff" isn't wanted.