bisect ui on Windows
(1.1) Originally by Ralf Hoermann (ralf1024) with edits by Richard Hipp (drh) on 2021-06-07 16:51:25 from 1.0 [source]
After doing a bisect, I tried to get a timeline that shows only the check-ins that are part of the bisect, like in this forum post. This is on Windows 10 Pro 64-Bit, fossil version 2.15 2c6012c4aa and Google Chrome as the default webbrowser:
P:\>fossil bisect ui Temporary files: C:\Users\user\AppData\Local\Temp\fossil_server_P8080* Listening for HTTP requests on TCP port 8080 Launch webbrowser: start http://localhost:8080/timeline?bisect & Type Ctrl-C to stop the HTTP server
The opened URL in Chrome is
http://localhost:8080/timeline?bisect, which basically displays an unfiltered timeline. While searching for a clue, I found the following line in timeline.c:
&& fossil_strcmp(g.zIpAddr,"127.0.0.1")==0
By changing the URL to
http://127.0.0.1:8080/timeline?bisect, I got the expected timeline filtered to the bisect. Can anyone reproduce this behavior?
(2) By Richard Hipp (drh) on 2021-06-07 16:37:32 in reply to 1.0 [link] [source]
Please visit http://localhost:8080/test_env and tell us what the value of
the REMOTE_ADDR environment variable is.
I think I know what is wrong. I think the fossil_strcmp() needs to be changed
into cgi_is_loopback(g.zIpAddr). But I want to confirm before checking in the
change, and knowledge of your REMOTE_ADDR will help with that.
(3) By Ralf Hoermann (ralf1024) on 2021-06-07 16:43:08 in reply to 2 [link] [source]
REMOTE_ADDR = ::1
(4) By Richard Hipp (drh) on 2021-06-07 16:49:29 in reply to 3 [link] [source]
That confirms my theory. A change has been checked in that should fix this. Please try again with check-in 2d79135b764968b9 or later and let us know.
(5.1) By Ralf Hoermann (ralf1024) on 2021-06-07 20:50:05 edited from 5.0 in reply to 4 [link] [source]
With check-in 2d79135b76, it works as expected. Thanks! I just noticed if I open the bisect URL in Firefox, it works with fossil 2c6012c4aa, and test_env reports
REMOTE_ADDR = 127.0.0.1