/ckout glitch when fossil ui invoked from subdirectory

(1.1) By MG (mgr) on 2024-12-13 11:41:12 edited from 1.0 [source]

I noticed thath the new /ckout page displays wrong stuff when fossil ui is invoked from a subdirectory of the checkout.

Files that should be CHANGED show as MISSING

eg in a checkout of fossil proper:

echo X >> README.md
cd src
fossil ui

** MISSING README.md **

instead of

** CHANGED README.md **

which shows when fossil ui is invoked from the root directory of the checkout.

Tested with latest version from trunk (3d2f1886a3e0d830) at the moment

(2) By Richard Hipp (drh) on 2024-12-13 12:21:11 in reply to 1.1 [link] [source]

Please rebuild using the latest trunk check-in and try again.

(3) By MG (mgr) on 2024-12-13 12:34:48 in reply to 2 [link] [source]

working perfectly fine now (@ 4af5cde63d).

Thank you.

(4.3) By MG (mgr) on 2024-12-13 12:55:48 edited from 4.2 in reply to 2 [link] [source]

Another note and humble suggestion on /ckout - which is a very nice feature, btw! Thank you.

It seems to react to query-params diff, w and dc the same way as eg. /vdiff and /ci, /vinfo do. So maybe add the "Hide Diffs"/"Side-by-Side Diffs"/"Unified Diffs", "Ignore Whitespace" buttons in the same manner as on /vdiff ... ?

Nevermind, I see you just added that (7cf712af979d10a7) while I was writing this message.

(5) By Richard Hipp (drh) on 2024-12-13 13:40:38 in reply to 4.3 [link] [source]

The /vdiff page still puts the controls below the main menu, rather than in between the context graph and the diffs. That is different from the /ckout and /info pages. Maybe they should all be the same? Or, perhaps the diff controls for /ckout should be the same as for /vdiff, rather than being the same as /info. I'm not sure.

I'd also like for the "Show/Hide" link to automatically rename itself to either "Show All" or "Hide All" depending on what it will do the next time it is clicked.

Probably I'll think of even more improvements as I continue to use it...

(6) By Florian Balmer (florian.balmer) on 2024-12-13 13:53:59 in reply to 5 [link] [source]

(2) Omit the "Hide Diffs" links, as those are now redundant.

I don't think these links are redundant, as they allow loading web UI pages containing diffs without (potentially expensive) server-side rendering, but with a list of links to open the diffs for each file, individually.

The new "show/hide" button won't skip the server-side rendering.

(7) By Richard Hipp (drh) on 2024-12-13 14:04:39 in reply to 6 [link] [source]

You can still add the "diff=0" query parameter on the URL manually. I think that feature is so uncommonly needed and/or useful that it does not deserve to take up space on the screen.

(8) By Florian Balmer (florian.balmer) on 2024-12-13 14:13:39 in reply to 7 [link] [source]

Fair enough. Though manually adding query parameters is now somewhat limited by the latest anti-bot defenses.

(9) By MG (mgr) on 2024-12-13 15:08:36 in reply to 5 [link] [source]

And on /vdiff, "ignore whitespace" is a checkbox, at least for me that is more clear than a 'command button' with "switch to other state".

In that sense, maybe the diff-mode could be a drop-down menu with

no diff
unified diff
side-by-side diff

like eg the 'view'-selector on /timeline.

Or three 'radio buttons', though the are not used in fossil IIRC and would use more screen space than a drop-down.

(10) By MG (mgr) on 2024-12-13 15:13:08 in reply to 5 [link] [source]

speaking of glitches with /ckout:

https://fossil-scm.org/home/ckout redirects to https://fossil-scm.org/home/%R/home (Not Found)

(11) By Florian Balmer (florian.balmer) on 2024-12-13 15:25:03 in reply to 9 [link] [source]

In that sense, maybe the diff-mode could be a drop-down menu ...

Direct links are faster than sub-menu / drop-down list navigation.

(12.1) By Stephan Beal (stephan) on 2024-12-13 23:41:25 edited from 12.0 in reply to 5 [link] [source]

I'd also like for the "Show/Hide" link to automatically rename itself to either "Show All" or "Hide All" depending on what it will do the next time it is clicked.

i will look into that. "The trick" there it is that it doesn't actually know what it's going to do when you click it. When clicked, it looks through the file-specific show/hide checkboxes. If any are unchecked (hidden) then it toggles all of them to revealed, else it hides all of them. Getting it to show that in advance will require that the checkboxes keep it abreast of their state while they're clicked. That's not a problem, per se, but it exceeded my ambitions during last night's coding ;).

Edit: done