Fossil Forum

Tip of trunk is now a release candidate
Login

Tip of trunk is now a release candidate

Tip of trunk is now a release candidate

(1) By Richard Hipp (drh) on 2023-09-28 14:49:39 [link] [source]

The latest trunk check-in is now considered a release candidate. If no objections are raised over the next couple of days, I will push out the official 2.23 release of Fossil based on the latest trunk.

Please run any tests you may have and send follow-up posts to this forum thread if you have objections.

Complete set of changes going back to the previous release: https://fossil-scm.org/home/timeline?p=trunk&bt=release

Latest change log: https://fossil-scm.org/home/doc/trunk/www/changes.wiki

(2) By John Rouillard (rouilj) on 2023-09-28 17:27:34 in reply to 1 [link] [source]

Hmm, is it expected that I have to add the package libssl-dev?

I was able to build fossil with SSL support as of version [b5aa9f8ab4] 2023-08-18 14:15:20 UTC without this new package.

The error was:

cc -I. -I./src -I./extsrc -Ibld -Wall -Wdeclaration-after-statement -DFOSSIL_ENABLE_JSON -DFOSSIL_ENABLE_TH1_HOOKS -DFOSSIL_DYNAMIC_BUILD=1  -g -O2 -DHAVE_AUTOCONFIG_H  -o bld/http_transport.o -c bld/http_transport_.c
./src/http_ssl.c:36:10: fatal error: openssl/bio.h: No such file or directory
 #include <openssl/bio.h>
          ^~~~~~~~~~~~~~~
compilation terminated.
src/main.mk:1377: recipe for target 'bld/http_ssl.o' failed

os:

Distributor ID: Ubuntu
Description:    Ubuntu 18.04.6 LTS
Release:        18.04
Codename:       bionic

OpenSSL 1.1.1  11 Sep 2018

Rebuilding after adding libssl-dev worked fine.

(3) By Stephan Beal (stephan) on 2023-09-28 17:33:11 in reply to 2 [link] [source]

Hmm, is it expected that I have to add the package libssl-dev?

It's always required that for SSL/TLS support. If configured with --with-openssl=none then it will build without SSL support, otherwise is requires the libssl-dev package (or equivalent - the libssl header files).

(4) By Richard Hipp (drh) on 2023-09-28 17:38:02 in reply to 2 [link] [source]

The only changes to the http_ssl.c source file since the last release are:

https://fossil-scm.org/home/fdiff?v1=6327207da26138b0&v2=d8f90458ff2bc23c

So I don't know how you were able to build before without libssl-dev.

The release binaries statically link against OpenSSL, which requires downloading and compiling OpenSSL first. There is a checklist on how to build the release binaries at https://fossil-scm.org/home/wiki?name=Release+Build+How-To. Maybe you can build that way without requiring libssl-dev?

(5.2) By John Rouillard (rouilj) on 2023-09-28 17:56:01 edited from 5.1 in reply to 4 [link] [source]

Hmm interesting.

Stephan, I have openssl=auto on my configure line.

Richard, I'm not sure how I was able to build either. Might have to do some spelunking in my apt logs to see if libssl-dev got removed recently. I also haven't done a full, clean rebuild in a while, so it might not have been removed that recently.

I'm not morally opposed to installing libssl-dev on my system. I just thought it was weird that I needed to add it and didn't remember having done so before.

Thanks for your feedback. This is resolved AFAIAC.

(6) By Richard Hipp (drh) on 2023-09-28 18:29:18 in reply to 2 [link] [source]

But the latest OpenSSL is version 3.1.2 (Just checked - looks like they have just recently added 3.1.3 - I'll upgrade before doing the release build). Maybe you should follow the checklist provided and build with the latest OpenSSL?

(7) By Richard Hipp (drh) on 2023-09-29 13:03:10 in reply to 1 [link] [source]

Release Delayed

A bug inserted by the enhanced defense against CSRF caused self-registration to stop working. The bug is fixed in check-in 6ae9941860bfade6.

I nearly did a release that contained this rather serious bug. That close call inspires me to delay the release a while longer, hoping to catch any other problems. Expression your agreement or disagreement with that choice in replies to this post.

(8) By Richard Hipp (drh) on 2023-09-29 13:43:48 in reply to 7 [link] [source]

Multiple new merges to trunk from user Preben. So the release is definitely delayed now - probably by a few weeks.

(9) By Preben Guldberg (preben) on 2023-09-29 13:47:54 in reply to 8 [link] [source]

My sincere apologies for that.

Certainly not what I intended.

(11) By Andy Bradford (andybradford) on 2023-10-01 20:49:25 in reply to 8 [link] [source]

Couldn't we  move [d6cdd955e133] to the  start of a new  branch and wait
until after the release has been tagged to merge it back in?

At least this wouldn't delay the release.

Andy

(13) By Larry Brasfield (larrybr) on 2023-10-02 00:51:17 in reply to 11 [source]

Couldn't we move [d6cdd955e133] to the start of a new branch ... ?

Has anybody demonstrated that the test failures are from stuff merged at or after [d6cdd955e133]?

The changes from that point onward look innocuous and relatively safe, but with cosmetic effects that would probably affect test results. Yet those merges have not touched the test suite. So I would expect some test breakages. If that sort of breakage is behind that flurry of errors, they should be fixable in short order. But if some of them represent earlier-generated discrepancies, moving those most recent changes to a branch is just part of what is needed for a release.

I hesitate to second guess Richard, but I think maybe he wants to see what's up before taking abrupt action.

(14) By Andy Bradford (andybradford) on 2023-10-02 02:29:13 in reply to 13 [link] [source]

The test  failures appear to  predate [d6cdd955e133], but  test failures
have rarely been a determining factor for Fossil releases.

I'll probably look at the amend test  failure when I get some spare time
since it's likely  that I wrote it  and some change in  behavior for how
tags are sorted changed got introduced.

Andy

(10) By Andy Bradford (andybradford) on 2023-10-01 15:27:33 in reply to 1 [link] [source]

There seem to be a high number of test failures on OpenBSD 7.2:

***** Final results: 65 errors out of 37607 tests
***** Considered failures: amend-tag-2.2 pre-commit-warnings-fossil-1 test-framework-diff merge1-2.1 merge1-2.2 merge1-4.1 merge1-4.2 merge1-7.1 merge1-7.2 merge3-3 merge3-4 merge3-5 merge3-6 merge3-7 merge3-8 merge3-11 merge3-24 merge3-25 merge3-34 merge3-35 merge3-44 merge3-45 merge3-54 merge3-55 merge3-64 merge3-65 merge3-74 merge3-75 merge3-84 merge3-85 merge3-94 merge3-95 merge3-103 merge3-104 merge4-1000 merge4-1002 test-framework-merge_renames test-framework-merge_renames_2 merge_warn-1 test-framework-mv-rm test-framework-revert test-framework-settings-repo settings-valid-local-auto-hyperlink-delay settings-valid-local-auto-hyperlink-mouseover settings-valid-local-chat-timeline-user settings-valid-local-dont-commit settings-valid-local-email-listid settings-valid-local-forum-close-policy settings-valid-local-large-file-size settings-valid-local-self-pw-reset settings-valid-global-auto-hyperlink-delay settings-valid-global-auto-hyperlink-mouseover settings-valid-global-chat-timeline-user settings-valid-global-dont-commit settings-valid-global-email-listid settings-valid-global-forum-close-policy settings-valid-global-large-file-size settings-valid-global-self-pw-reset test-framework-stash test-framework-th1-repo th1-trace-2 th1-trace-4 th1-defHeader-2 th1-info-commands-1 test-framework-unversioned
***** Ignored results: 1 ignored errors out of 37607 tests
***** Ignored failures: merge5-sqlite3-issue

I wonder what all  the merge failures are about? I  haven't had a chance
to look into them.


Andy

(12) By John Rouillard (rouilj) on 2023-10-01 22:46:58 in reply to 10 [link] [source]

That pretty much matches (in quantity) what I get on Ubuntu 18.04:

***** Final results: 68 errors out of 38306 tests
***** Considered failures: amend-tag-2.2 test-framework-diff json-login-c-m json-login-c-n json-login-c-c merge1-2.1 merge1-2.2 merge1-4.1 merge1-4.2 merge1-7.1 merge1-7.2 merge3-3 merge3-4 merge3-5 merge3-6 merge3-7 merge3-8 merge3-11 merge3-24 merge3-25 merge3-34 merge3-35 merge3-44 merge3-45 merge3-54 merge3-55 merge3-64 merge3-65 merge3-74 merge3-75 merge3-84 merge3-85 merge3-94 merge3-95 merge3-103 merge3-104 merge4-1000 merge4-1002 test-framework-merge_renames test-framework-merge_renames_2 merge_warn-1 test-framework-mv-rm test-framework-revert test-framework-settings-repo settings-valid-local-auto-hyperlink-delay settings-valid-local-auto-hyperlink-mouseover settings-valid-local-chat-timeline-user settings-valid-local-dont-commit settings-valid-local-email-listid settings-valid-local-forum-close-policy settings-valid-local-large-file-size settings-valid-local-self-pw-reset settings-valid-global-auto-hyperlink-delay settings-valid-global-auto-hyperlink-mouseover settings-valid-global-chat-timeline-user settings-valid-global-dont-commit settings-valid-global-email-listid settings-valid-global-forum-close-policy settings-valid-global-large-file-size settings-valid-global-self-pw-reset test-framework-stash test-framework-symlinks test-framework-th1-repo th1-trace-2 th1-trace-4 th1-defHeader-2 th1-info-commands-1 test-framework-unversioned
***** Ignored results: 3 ignored errors out of 38306 tests
***** Ignored failures: json-cap-POSTenv-name json-env-RC-1103-code merge5-sqlite3-issue

so what you aren't seeing isn't just a platform issue.