Fossil Forum

Forum
Login

"make -f Makefile.classic" does nothing

(1) By pmacdona on 2020-01-21 23:19:06

It looks like the culprit is APPNAME got removed.
As usual, apologies if was already reported...

--- src/main.mk.orig	2020-01-21 15:08:53.024415215 -0800
+++ src/main.mk	2020-01-21 15:08:54.936415268 -0800
@@ -511,6 +511,9 @@
  $(OBJDIR)/xfer.o \
  $(OBJDIR)/xfersetup.o \
  $(OBJDIR)/zip.o
+
+APPNAME = fossil$(E)
+
 all:	$(OBJDIR) $(APPNAME)
 
 install:	all

(2) By stephan on 2020-01-22 00:41:58 [link] in reply to 1

TL;DR: the fix actually belongs in Makefile.classic (see below), and i will commit it as soon as my local tests are done.

Details:

That seems to have been a casualty of the port to autosetup (ages ago - apparently few people use that makefile). main.mk is generated from src/makemake.tcl, but we can't inject APPNAME there without also refactoring Makefile.in, which defines APPNAME immediately before it imports main.mk.

The fix, it seems, is to have Makefile.classic follow the same pattern as Makefile.in, and add:

APPNAME = fossil$(E)

Near the bottom of Makefile.classic, before:

include $(SRCDIR)/main.mk

Thank you for the report!

(3) By pmacdona on 2020-01-22 03:10:32 [link] in reply to 2

Ah thanks. I figured it was something like that.