Minor responsive CSS glitches
(1) By Florian Balmer (florian.balmer) on 2018-08-20 21:08:58 [link] [source]
I've just noticed a few minor glitches with the new responsive CSS:
- The top menu bar seems to be a bit too low, it has vertical scrollbars on the right, and the orange line at the bottom of the active item ("Code") is no longer visible.
- In the File List, some file names are truncated ("cson_amalgamation.*").
The Screenshot was taken with Chromium 70.0.3529.0 on Windows 10.0.17134.228 with 100% DPI scaling.
(For testing, the image was embedded in the forum post with <img src="data:image/png;base64,...">
. This seems to work fine, although it's about 58 KB of data, whereas the original PNG file is around 43 KB.)
(2) By Warren Young (wyoung) on 2018-08-20 21:36:52 in reply to 1 [source]
I approved this posting for the information content and its value as a test, but I've got to say that I oppose using data URLs in image tags to get around the current inability to post images: it's rather unkind to those receiving email notifications for us to hexbarf in their inbox.
Once we have a better way to post inline images, it might be worth making it a forum rule that such things are not allowed, so that the moderators can cite the rule when rejecting such postings.
(3) By Richard Hipp (drh) on 2018-08-20 23:40:22 in reply to 1 [link] [source]
I increased the column width by 10%, which seems to have cleared the truncated filename problem on Chrome. (It always worked correctly on Firefox, FWIW.) I still do not understand why the menu bar is vertical scrolling by one pixel. Hints are welcomed.
(9) By Martin Gagnon (mgagnon) on 2018-08-22 14:41:14 in reply to 3 [link] [source]
On my system, even on Firefox it doesn't always display correctly. (Firefox 52.9.0 ESR on debian-8)
If I change zoom factor (ctrl++ and ctrl+-), I get different result.
On my actual system , It only shows correctly with 90% zoom.
In all other zoom factor, sometimes I see the vertical scrollbar, sometimes not, but there's always missing pixels on bottom.
I've Also got similar result on different browser / OSes combination:
- Chrome on Debian-8
- On Mobile (Safari and Chrome on IOS)
- Chrome and Edge on Windows 10
(4) By Florian Balmer (florian.balmer) on 2018-08-21 05:19:31 in reply to 1 [link] [source]
I'm sorry I didn't think of e-mail notifications getting bloated by the inline image. I know it's a bad technique, but I was too excited checking out the new features ...
The file names are now no longer truncated in Chromium, thanks for the fix!
(5) By Richard Hipp (drh) on 2018-08-21 12:50:24 in reply to 4 [link] [source]
The file names are now no longer truncated in Chromium, thanks for the fix!
Yeah, but the menu bar is still vertical scrolling by a single pixel. I do not understand why it is doing that. Suggestions on how to fix that will be greatly appreciated.
(6) By Warren Young (wyoung) on 2018-08-21 20:05:54 in reply to 5 [link] [source]
Such things can be very difficult to chase down, since they change between browsers, and they can often depend on order of operations.
Rather than fight past that, just tell the browser what you want it to do:
div.mainmenu {
overflow-y: hidden;
}
That means if it's got a choice between scrolling vertically and clipping the content off, it should clip it off.
It's tested and working here, though as I said, it can be state- and browser-dependent, so this might not be the last CSS workaround you need.
(10) By Warren Young (wyoung) on 2018-09-01 19:16:45 in reply to 6 [link] [source]
overflow-y: hidden;
I see that the skins on fossil-scm.org were updated recently, but this suggestion wasn't included in the new versions.
Consequently, I'm still occasionally getting unwanted scroll bars in the navbar. I see this in Chrome, Firefox, and Safari on macOS.
Should I just check this in as a change to the skins?
(11) By Richard Hipp (drh) on 2018-09-01 19:22:32 in reply to 10 [link] [source]
Yes, please.
(12) By Warren Young (wyoung) on 2018-09-01 20:20:40 in reply to 11 [link] [source]
It's done. See the checkin comment for details.
(13) By Warren Young (wyoung) on 2018-09-01 20:39:23 in reply to 12 [link] [source]
More thoughts on navbar responsive design:
You can see a demo of this before applying it to your own repos by visiting my MySQL++ repository. The skin is modified from the default, but the navbar overflow stuff is still stock, and updated to match Fossil tip-of-trunk.
A variation some may find valuable is to set both overflow values to "hidden" as I did on my PiDP-8/I repo. I like this better when the skin background is a warm color, since the white-and-gray macOS horizontal scroll bar added when the navbar is too wide clashes with the background.
I've moved my hamburger button to the start of the bar on both repos as a consequence of these recent changes, so it's always visible by default.
Avoid the temptation to combine the two
overflow-*
directives into one. Browsers haven't always followed the spec, which says Y first, then X, so combining them gives inconsistent results across platforms.
(14) By Florian Balmer (florian.balmer) on 2018-09-02 07:04:29 in reply to 12 [link] [source]
The vertical scrollbar is now gone, but the orange border at the bottom of the active menu item is still not visible (verified that .mainmenu { overflow-y: hidden; }
is present).
Also note the split folder icons I was trying to explain earlier.
The Screenshot was taken with Chromium 71.0.3540.0 at 100% zoom level on Windows 10.0.17134.254 at 100% DPI scaling.
(7) By Warren Young (wyoung) on 2018-08-21 20:17:52 in reply to 4 [link] [source]
I'm sorry I didn't think of e-mail notifications getting bloated by the inline image.
Think of it this way: Someone had to try it, if only to test for edge cases, and you got to it first. Now that we have the test case, no one has to do that to anyone else ever again. :)
Alternate workaround: the email builder could find such tags and replace them just as a screen reader does. Use the alt tag if possible, else use stock text like "<inline image>".
(8) By Florian Balmer (florian.balmer) on 2018-08-21 20:32:54 in reply to 7 [link] [source]
Think of it this way: Someone had to try it ...
Thanks for the rehabilitation ... ;-)
Another issue: also with Chromium, if the window is wide enough to allow for more columns than there's files or directories(*), the file and folder icons are "split" into upper and lower halves, and are scattered across multiple columns, i.e. the upper half of the icon goes in a column by itself, and the lower half is near the text in the next column.
(*) Try the following links with a maximized browser window on a desktop PC:
- https://www.sqlite.org/src/dir?ci=1e29fd430dead641&name=contrib (does the check-in hash already call for trouble ... ?)
- https://www.fossil-scm.org/index.html/dir?ci=1d495e89e24896de&name=compat
I'm sorry I'm not helpful at all with CSS, apart form a few basics, I'm not brave enough for this jungle of vendor specifics and browser incompatibilities ...
(15) By Richard Hipp (drh) on 2018-09-02 10:09:36 in reply to 8 [link] [source]
Try it now, after check-in e585c3e676a9f415
(16) By Florian Balmer (florian.balmer) on 2018-09-02 13:21:16 in reply to 15 [link] [source]
Problem solved, thank you very much!
As there's no (public) ticket system to indicate whether a problem is acknowledged, assigned to somebody, and scheduled for fixing, I sometimes write another message on one and the same topic.
This is not necessarily because I'm impatient (I'm happy with Fossil 2.6 as my "daily driver"), but because I think small problems are easier to fix while working on the surrounding code, and not after shipping the next release.