Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
| Comment: | Disabling the "auto paragraph" feature in the wiki renderer when styling
an HTML "table" element. Without this, the first cell's contents gets
wrapped in "p" tags, unnecessarily. (None of the other cells are treated thus.) With the trunk default skin, this extra tag was invisible,
but with this branch's skin, it shows up as a double-height first row in
every table. For tables with a header row, this may appear to be an
intentional esthetic choice, but it's not; it's a rendering bug.
Credit for this goes to Stephan Beal (the eminent repo archaeologist) plus whichever "anonymous" posted this ticket, way back in 2010! |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | inskinerator-modern-backport |
| Files: | files | file ages | folders |
| SHA3-256: |
6f94da9b6b2b049cbc4e0061cee659b3 |
| User & Date: | wyoung 2024-02-03 23:03:18 |
| Original Comment: | Disabling the "auto paragraph" feature in the wiki renderer when styling
an HTML "table" element. Without this, the first cell's contents gets
wrapped in "p" tags, unnecessarily. (None of the other cells get this
effect.) With thie trunk default skin, this extra tag was invisible,
but with this branch's skin, it shows up as a double-height first row in
every table. For tables with a header row, this may appear to be an
intentional feature, but it's not; it's a rendering bug.
Credit for this goes to Stephan Beal (the eminemnt repo archaeologist) plus whichever "anonymous" posted this ticket, way back in 2010! |
References
|
2024-02-03
| ||
| 23:05 | • Closed ticket [0fd3c7d2]: wiki inserts P tags in tables plus 5 other changes ... (artifact: 38dd720d user: wyoung) | |
Context
|
2024-02-03
| ||
| 23:12 | Merged trunk. Notably, drh's [bb3de39ffefb3f20] works seamlessly with this branch's skin. ... (check-in: 4f9cb1d1 user: wyoung tags: inskinerator-modern-backport) | |
| 23:03 |
Disabling the "auto paragraph" feature in the wiki renderer when styling
an HTML "table" element. Without this, the first cell's contents gets
wrapped in "p" tags, unnecessarily. (None of the other cells are treated thus.) With the trunk default skin, this extra tag was invisible,
but with this branch's skin, it shows up as a double-height first row in
every table. For tables with a header row, this may appear to be an
intentional esthetic choice, but it's not; it's a rendering bug.
Credit for this goes to Stephan Beal (the eminent repo archaeologist) plus whichever "anonymous" posted this ticket, way back in 2010! ... (check-in: 6f94da9b user: wyoung tags: inskinerator-modern-backport) | |
|
2024-01-28
| ||
| 22:52 | Merged all trunk changes in except for the underlined link change to default.css. ... (check-in: 6301f6ce user: wyoung tags: inskinerator-modern-backport) | |
Changes
Changes to src/wikiformat.c.
| ︙ | ︙ | |||
1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 |
}else
if( markup.iType==MUTYPE_TD ){
if( backupToType(p, MUTYPE_TABLE|MUTYPE_TR) ){
if( stackTopType(p)==MUTYPE_TABLE ){
pushStack(p, MARKUP_TR);
blob_append_string(p->pOut, "<tr>");
}
pushStack(p, markup.iCode);
renderMarkup(p->pOut, &markup);
}
}else
if( markup.iType==MUTYPE_HYPERLINK ){
if( !isButtonHyperlink(p, &markup, z, &n) ){
popStackToTag(p, markup.iCode);
| > | 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 |
}else
if( markup.iType==MUTYPE_TD ){
if( backupToType(p, MUTYPE_TABLE|MUTYPE_TR) ){
if( stackTopType(p)==MUTYPE_TABLE ){
pushStack(p, MARKUP_TR);
blob_append_string(p->pOut, "<tr>");
}
p->wantAutoParagraph = 0;
pushStack(p, markup.iCode);
renderMarkup(p->pOut, &markup);
}
}else
if( markup.iType==MUTYPE_HYPERLINK ){
if( !isButtonHyperlink(p, &markup, z, &n) ){
popStackToTag(p, markup.iCode);
|
| ︙ | ︙ |