Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
| Comment: | The new test_block_in_checkout proc in tester.tcl was not setting the CODE and RESULT global variables when it skipped a test, so there was a chance that a test would end up checking the prior values and throw a false positive. |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | wrap-run_in_checkout |
| Files: | files | file ages | folders |
| SHA3-256: |
2aaee4841e0f7587538dd19791466f1b |
| User & Date: | wyoung 2018-09-03 06:15:39 |
Context
|
2018-09-03
| ||
| 06:19 | Fixed a Tcl syntax error checked in with [33efa2fa]. (Yay dynamic languages that run the code even if it's syntactically invalid. P'tui!) (check-in: 4315d464 user: wyoung tags: wrap-run_in_checkout) | |
| 06:15 | The new test_block_in_checkout proc in tester.tcl was not setting the CODE and RESULT global variables when it skipped a test, so there was a chance that a test would end up checking the prior values and throw a false positive. (check-in: 2aaee484 user: wyoung tags: wrap-run_in_checkout) | |
| 06:13 | Fixed a Tcl logic error committed with [33efa2fa]. (check-in: 02430597 user: wyoung tags: wrap-run_in_checkout) | |
Changes
Changes to test/tester.tcl.
548 549 550 551 552 553 554 555 556 557 558 559 560 561 |
# optional post-run test script. Some callers choose instead to put
# the tests inline with the rscript commands.
#
# Be sure to adhere to the requirements of run_in_checkout!
proc test_block_in_checkout { name rscript {tscript ""} } {
if {$::outside_fossil_repo} {
puts "Skipping $name test: not in Fossil repo checkout."
} else {
run_in_checkout $rscript
if {[string length $tscript] == 0} {
return ""
} else {
set code [catch {
uplevel 1 $tscript
|
> > |
548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 |
# optional post-run test script. Some callers choose instead to put
# the tests inline with the rscript commands.
#
# Be sure to adhere to the requirements of run_in_checkout!
proc test_block_in_checkout { name rscript {tscript ""} } {
if {$::outside_fossil_repo} {
puts "Skipping $name test: not in Fossil repo checkout."
set $::CODE 0
set $::RESULT ""
} else {
run_in_checkout $rscript
if {[string length $tscript] == 0} {
return ""
} else {
set code [catch {
uplevel 1 $tscript
|