Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
| Comment: | Partially reverted one of the run_in_checkout replacements in test/th1.test: it was inside a foreach loop, which means the test for whether we're inside the Fossil repo checkout was being done 26 times. This is not only inefficient, it spammed the output with "Skipping test blabla..." lines. Now doing a manual check outside the loop and skipping the in-repo tests silently inside the loop. |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | wrap-run_in_checkout |
| Files: | files | file ages | folders |
| SHA3-256: |
3cb1b4f0a4e1f8b880d6589007b7b4ff |
| User & Date: | wyoung 2018-09-03 06:22:54 |
Context
|
2018-09-03
| ||
| 06:27 | The test harness now skips all tests done in the Fossil source repo checkout directory while there are uncommitted changes because that will affect the behavior of fossil status, fossil diff, etc., which in turn tends to create false positives in test harness code that checks for changes in fossil command output. (Closed-Leaf check-in: 78ec6838 user: wyoung tags: wrap-run_in_checkout) | |
| 06:22 | Partially reverted one of the run_in_checkout replacements in test/th1.test: it was inside a foreach loop, which means the test for whether we're inside the Fossil repo checkout was being done 26 times. This is not only inefficient, it spammed the output with "Skipping test blabla..." lines. Now doing a manual check outside the loop and skipping the in-repo tests silently inside the loop. (check-in: 3cb1b4f0 user: wyoung tags: wrap-run_in_checkout) | |
| 06:19 | Fixed a Tcl syntax error checked in with [33efa2fa]. (Yay dynamic languages that run the code even if it's syntactically invalid. P'tui!) (check-in: 4315d464 user: wyoung tags: wrap-run_in_checkout) | |
Changes
Changes to test/th1.test.
551
552
553
554
555
556
557
558
559
560
561
562
563
564
...
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
|
###############################################################################
fossil test-th-eval "lindex list -0x"
test th1-expr-49 {$RESULT eq {TH_ERROR: expected integer, got: "-0x"}}
###############################################################################
foreach perm [list a b c d e f g h i j k l m n o p q r s t u v w x y z] {
if {$perm eq "u"} continue; # NOTE: Skip "reader" meta-permission.
if {$perm eq "v"} continue; # NOTE: Skip "developer" meta-permission.
fossil test-th-eval "anycap $perm"
test th1-anycap-no-$perm-1 {$RESULT eq {0}}
................................................................................
fossil test-th-eval "hascap $perm"
test th1-hascap-no-$perm-1 {$RESULT eq {0}}
fossil test-th-eval "anoncap $perm"
test th1-anoncap-no-$perm-1 {$RESULT eq {0}}
test_block_in_checkout "th1-anycap-*-1 perm" {
fossil test-th-eval --set-user-caps "anycap $perm"
test th1-anycap-yes-$perm-1 {$RESULT eq {1}}
set ::env(TH1_TEST_USER_CAPS) 1; # NOTE: Bad permission.
fossil test-th-eval --set-user-caps "anycap $perm"
test th1-anycap-no-$perm-1 {$RESULT eq {0}}
unset ::env(TH1_TEST_USER_CAPS)
|
>
>
>
>
>
>
>
>
>
|
|
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
...
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
|
###############################################################################
fossil test-th-eval "lindex list -0x"
test th1-expr-49 {$RESULT eq {TH_ERROR: expected integer, got: "-0x"}}
###############################################################################
set skip_anycap 1
if {$::outside_fossil_repo} {
puts "Skipping th1-anycap-*-1 perm tests: not in Fossil repo checkout."
} else {
set skip_anycap 0
}
foreach perm [list a b c d e f g h i j k l m n o p q r s t u v w x y z] {
if {$perm eq "u"} continue; # NOTE: Skip "reader" meta-permission.
if {$perm eq "v"} continue; # NOTE: Skip "developer" meta-permission.
fossil test-th-eval "anycap $perm"
test th1-anycap-no-$perm-1 {$RESULT eq {0}}
................................................................................
fossil test-th-eval "hascap $perm"
test th1-hascap-no-$perm-1 {$RESULT eq {0}}
fossil test-th-eval "anoncap $perm"
test th1-anoncap-no-$perm-1 {$RESULT eq {0}}
if {$skip_anycap} { continue }
run_in_checkout {
fossil test-th-eval --set-user-caps "anycap $perm"
test th1-anycap-yes-$perm-1 {$RESULT eq {1}}
set ::env(TH1_TEST_USER_CAPS) 1; # NOTE: Bad permission.
fossil test-th-eval --set-user-caps "anycap $perm"
test th1-anycap-no-$perm-1 {$RESULT eq {0}}
unset ::env(TH1_TEST_USER_CAPS)
|