Fossil

Check-in [4315d464]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fixed a Tcl syntax error checked in with [33efa2fa]. (Yay dynamic languages that run the code even if it's syntactically invalid. P'tui!)
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | wrap-run_in_checkout
Files: files | file ages | folders
SHA3-256: 4315d4646280b86039bb887f133d8b2f8a3590d21fd000940dc25282e3b2c198
User & Date: wyoung 2018-09-03 06:19:13.853
Context
2018-09-03
06:22
Partially reverted one of the run_in_checkout replacements in test/th1.test: it was inside a foreach loop, which means the test for whether we're inside the Fossil repo checkout was being done 26 times. This is not only inefficient, it spammed the output with "Skipping test blabla..." lines. Now doing a manual check outside the loop and skipping the in-repo tests silently inside the loop. ... (check-in: 3cb1b4f0 user: wyoung tags: wrap-run_in_checkout)
06:19
Fixed a Tcl syntax error checked in with [33efa2fa]. (Yay dynamic languages that run the code even if it's syntactically invalid. P'tui!) ... (check-in: 4315d464 user: wyoung tags: wrap-run_in_checkout)
06:15
The new test_block_in_checkout proc in tester.tcl was not setting the CODE and RESULT global variables when it skipped a test, so there was a chance that a test would end up checking the prior values and throw a false positive. ... (check-in: 2aaee484 user: wyoung tags: wrap-run_in_checkout)
Changes
Unified Diff Ignore Whitespace Patch
Changes to test/th1.test.
︙︙
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680

}

###############################################################################

test_in_checkout th1-checkout-1 {
  # NOTE: The "1" here forces the checkout to be opened.
  fossil test-th-eval "checkout 1"
} [string length $RESULT] > 0}

###############################################################################

test_in_checkout th1-checkout-2 {
  if {$th1Hooks} {
    fossil test-th-eval "checkout"
  } else {








|








666
667
668
669
670
671
672
673
674
675
676
677
678
679
680

}

###############################################################################

test_in_checkout th1-checkout-1 {
  # NOTE: The "1" here forces the checkout to be opened.
  fossil test-th-eval "checkout 1"
} {[string length $RESULT] > 0}

###############################################################################

test_in_checkout th1-checkout-2 {
  if {$th1Hooks} {
    fossil test-th-eval "checkout"
  } else {
︙︙