Fossil

Check-in [8918a8a8]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Increased the transition delay to make the initial drop-down animation happen in Firefox 62.
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | js-hamburger-menu
Files: files | file ages | folders
SHA3-256: 8918a8a80a488a97ee6891f023396a920a8ed3a44b7627e8b4420f706cbc7eae
User & Date: wyoung 2018-09-10 09:02:29.365
Context
2018-09-10
09:27
Removed the
wrapping
    and moved the multicolumn styling applied to it down to the
      , since it is already a block level element, so we don't need a div wrapper on it. And then there's the real reason, which is that we want the multicolumn styling to work on the drop-down hamburger menu version as well.
... (check-in: 0d391a1b user: wyoung tags: js-hamburger-menu)
09:02
Increased the transition delay to make the initial drop-down animation happen in Firefox 62. ... (check-in: 8918a8a8 user: wyoung tags: js-hamburger-menu)
08:48
Using CSS transitions to mimic jQuery's slideUp/Down() transitions. This probably restricts browser compatibility still further above the XHR issue noted in the earlier checkin on this branch. According to MDN, we're probably restricted to IE 10+ with this, and maybe not even that due to not using vendor-specific extensions for the transitional browser versions. ... (check-in: 90bd6675 user: wyoung tags: js-hamburger-menu)
Changes
Unified Diff Ignore Whitespace Patch
Changes to skins/default/footer.txt.
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
    // *transition*, hence never kicks off the *CSS* transition:
    //
    // https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Transitions/Using_CSS_transitions#JavaScript_examples
    function showPanel() {
      setTimeout(function() {
        panel.style.maxHeight = panelHeight;
        panel.style.border    = panelBorder;
      }, 10);
    }

    // Click handler for the hamburger button.
    var needSitemapHTML = true;
    document.querySelector("div.mainmenu > a").onclick = function() {
      if (panel.style.maxHeight == panelHeight) {
        // Hamburger button clicked while panel visible.  Trigger the







|







43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
    // *transition*, hence never kicks off the *CSS* transition:
    //
    // https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Transitions/Using_CSS_transitions#JavaScript_examples
    function showPanel() {
      setTimeout(function() {
        panel.style.maxHeight = panelHeight;
        panel.style.border    = panelBorder;
      }, 25);   // 10 is insufficient with Firefox 62
    }

    // Click handler for the hamburger button.
    var needSitemapHTML = true;
    document.querySelector("div.mainmenu > a").onclick = function() {
      if (panel.style.maxHeight == panelHeight) {
        // Hamburger button clicked while panel visible.  Trigger the