Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
| Comment: | Zeroed a pointer in its declaration to squish a warning from GCC 4.8.4 on Ubuntu 14.04 about use of a potentially uninitted pointer. I don't think it's actually possible for the current code to use the pointer in the window between its declaration and first use, but I think we can afford the extra machine instruction this will cost us. (I assume newer GCCs are smart enough to analyze this situation correctly, which is why the warning hasn't been squished earlier.) |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | trunk |
| Files: | files | file ages | folders |
| SHA3-256: |
892781cb23c0335fea36b45a28bb2436 |
| User & Date: | wyoung 2018-08-11 19:28:17 |
Context
|
2018-08-11
| ||
| 19:43 | Added the "Enable Forum Search" section to www/forum.wiki (check-in: cc5d2e1f user: wyoung tags: trunk) | |
| 19:28 | Zeroed a pointer in its declaration to squish a warning from GCC 4.8.4 on Ubuntu 14.04 about use of a potentially uninitted pointer. I don't think it's actually possible for the current code to use the pointer in the window between its declaration and first use, but I think we can afford the extra machine instruction this will cost us. (I assume newer GCCs are smart enough to analyze this situation correctly, which is why the warning hasn't been squished earlier.) (check-in: 892781cb user: wyoung tags: trunk) | |
|
2018-08-10
| ||
| 23:28 | Try to put the human name of the person who posted on the From: line of email notifications for new forum posts. (check-in: ad419331 user: drh tags: trunk) | |
Changes
Changes to src/forum.c.
152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 |
/* Establish which entries are the latest edit. After this loop
** completes, entries that have non-NULL pLeaf should not be
** displayed.
*/
for(pEntry=pThread->pFirst; pEntry; pEntry=pEntry->pNext){
if( pEntry->fprev ){
ForumEntry *pBase, *p;
p = forumentry_backward(pEntry->pPrev, pEntry->fprev);
pEntry->pEdit = p;
while( p ){
pBase = p;
p->pLeaf = pEntry;
p = pBase->pEdit;
}
|
| |
152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 |
/* Establish which entries are the latest edit. After this loop
** completes, entries that have non-NULL pLeaf should not be
** displayed.
*/
for(pEntry=pThread->pFirst; pEntry; pEntry=pEntry->pNext){
if( pEntry->fprev ){
ForumEntry *pBase = 0, *p;
p = forumentry_backward(pEntry->pPrev, pEntry->fprev);
pEntry->pEdit = p;
while( p ){
pBase = p;
p->pLeaf = pEntry;
p = pBase->pEdit;
}
|