Fossil

Check-in [e54095f9]
Login

Check-in [e54095f9]

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fixed the panel.style.hasOwnProperty() test in the default skin's js.txt so that it will work on IE8 and below. See code comment for rationale.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: e54095f9af464436c1c83c0db6bd21b8beb4743a197adb5edb39e63e6671b562
User & Date: wyoung 2018-09-20 11:21:20
Context
2018-09-20
13:35
Fix the default CSS for the "columns" class to avoid breaking column breaks within a single <li> element. ... (check-in: 51da3966 user: drh tags: trunk)
11:21
Fixed the panel.style.hasOwnProperty() test in the default skin's js.txt so that it will work on IE8 and below. See code comment for rationale. ... (check-in: e54095f9 user: wyoung tags: trunk)
10:31
Allow /sitemap to accept the popup query parameter as GET as long as the incoming request is from the same origin. This is probably sufficient to prevent revealing URLs to robots. And the use of GET seems to be more in keeping with the REST idea. ... (check-in: 2804c71a user: drh tags: trunk)
Changes
Unified Diff Ignore Whitespace Patch
Changes to skins/default/js.txt.
︙︙
17
18
19
20
21
22
23





24



25
26
27
28
29
30
31

** Currently, the only thing this does is handle clicks on its hamburger
** menu button.
*/
(function() {
  var panel = document.getElementById("hbdrop");
  if (!panel) return;   // site admin might've nuked it
  var panelBorder = panel.style.border;





  var animate = panel.style.hasOwnProperty('transition');



  var animMS = 400;

  // Calculate panel height despite its being hidden at call time.
  // Based on https://stackoverflow.com/a/29047447/142454
  var panelHeight;  // computed on sitemap load
  function calculatePanelHeight() {
    // Get initial panel styles so we can restore them below.








>
>
>
>
>
|
>
>
>








17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39

** Currently, the only thing this does is handle clicks on its hamburger
** menu button.
*/
(function() {
  var panel = document.getElementById("hbdrop");
  if (!panel) return;   // site admin might've nuked it
  var panelBorder = panel.style.border;

  // Disable animation if this browser doesn't support CSS transitions.
  //
  // We need this ugly calling form for IE < 9 since it doesn't give you
  // a true Object for host-provided values such as 'panel'.  That is,
  // panel.style.hasOwnProperty() doesn't exist on IE8!  Since the whole
  // point of this test is to allow the code below to run without a JS
  // error on deficient browsers, we can't just ignore this problem.
  var animate = Object.prototype.hasOwnProperty.call(panel.style, 'transition');
  var animMS = 400;

  // Calculate panel height despite its being hidden at call time.
  // Based on https://stackoverflow.com/a/29047447/142454
  var panelHeight;  // computed on sitemap load
  function calculatePanelHeight() {
    // Get initial panel styles so we can restore them below.
︙︙