Fossil

Check-in [f423b10f]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Do not double-prompt for HttpAuth passwords.
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: f423b10f7930e77324a9fce2b2e4d05eff7fd0370da4258bde39c699ad38c279
User & Date: drh 2017-06-06 17:49:23.826
Context
2017-06-06
17:53
Bug fix in the sha3sum() routine. Also comment-out that routine since it is not used anyplace in the code. ... (check-in: 6419592d user: drh tags: trunk)
17:49
Do not double-prompt for HttpAuth passwords. ... (check-in: f423b10f user: drh tags: trunk)
2017-06-02
02:23
Restore the ability to amend a comment both with and without an interactive editor. If the edit happens outside a working check-out then use a suitable TMP directory. ... (check-in: 1fff403a user: andybradford tags: trunk)
Changes
Unified Diff Ignore Whitespace Patch
Changes to src/http.c.
︙︙
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188

  if ( g.url.user && g.url.passwd && use_fossil_creds_for_httpauth_prompt() ){
    zHttpAuth = mprintf("%s:%s", g.url.user, g.url.passwd);
  }else{
    prompt_user("Basic Authorization user: ", &x);
    zUser = mprintf("%b", &x);
    zPrompt = mprintf("HTTP password for %b: ", &x);
    blob_reset(&x);
    prompt_for_password(zPrompt, &x, 1);
    zPw = mprintf("%b", &x);
    zHttpAuth = mprintf("%s:%s", zUser, zPw);
    free(zUser);
    free(zPw);
    free(zPrompt);
    blob_reset(&x);
  }








|








174
175
176
177
178
179
180
181
182
183
184
185
186
187
188

  if ( g.url.user && g.url.passwd && use_fossil_creds_for_httpauth_prompt() ){
    zHttpAuth = mprintf("%s:%s", g.url.user, g.url.passwd);
  }else{
    prompt_user("Basic Authorization user: ", &x);
    zUser = mprintf("%b", &x);
    zPrompt = mprintf("HTTP password for %b: ", &x);
    blob_reset(&x);
    prompt_for_password(zPrompt, &x, 0);
    zPw = mprintf("%b", &x);
    zHttpAuth = mprintf("%s:%s", zUser, zPw);
    free(zUser);
    free(zPw);
    free(zPrompt);
    blob_reset(&x);
  }
︙︙