Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
Comment: | Roll back the part of [71a2d68a7a113e7c] which automatically updates the user display prefs cookie, per /chat discussion. Updating the cookie once again requires an explicit udc URL arg or setting the skin, which implies udc. This fixes the problem that a timeline link from the /reports page persistently sets the default timeline entry count to the value used by that report. |
---|---|
Downloads: | Tarball | ZIP archive | SQL archive |
Timelines: | family | ancestors | descendants | both | trunk |
Files: | files | file ages | folders |
SHA3-256: |
5feac634737660e03bc0f5761d2cff7c |
User & Date: | stephan 2023-01-16 15:37:53 |
Context
2023-01-16
| ||
18:14 | Update the built-in SQLite to the latest 3.41.0 alpha version in order to silence harmless compiler warnings and for general testing of SQLite. ... (check-in: cdd89e2d user: drh tags: trunk) | |
15:37 | Roll back the part of [71a2d68a7a113e7c] which automatically updates the user display prefs cookie, per /chat discussion. Updating the cookie once again requires an explicit udc URL arg or setting the skin, which implies udc. This fixes the problem that a timeline link from the /reports page persistently sets the default timeline entry count to the value used by that report. ... (check-in: 5feac634 user: stephan tags: trunk) | |
2023-01-13
| ||
18:38 | Backout change on "login-group join" command which broke the usage of it outside an opened checkout (using -R flag). Change usage text to match the command behavior properly when using the -R flag. ... (check-in: edf03559 user: mgagnon tags: trunk) | |
Changes
Changes to src/cgi.c.
︙ | ︙ | |||
1207 1208 1209 1210 1211 1212 1213 | int rc = 0; char * z = (char*)P("QUERY_STRING"); if( z ){ ++rc; z = fossil_strdup(z); add_param_list(z, '&'); z = (char*)P("skin"); | | | > > > > | 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 | int rc = 0; char * z = (char*)P("QUERY_STRING"); if( z ){ ++rc; z = fossil_strdup(z); add_param_list(z, '&'); z = (char*)P("skin"); if( z ){ char *zErr = skin_use_alternative(z, 2); ++rc; if( !zErr && P("once")==0 ){ cookie_write_parameter("skin","skin",z); /* Per /chat discussion, passing ?skin=... without "once" ** implies the "udc" argument, so we force that into the ** environment here. */ cgi_set_parameter_nocopy("udc", "1", 1); } fossil_free(zErr); } } return rc; } |
︙ | ︙ |
Changes to src/cookies.c.
︙ | ︙ | |||
173 174 175 176 177 178 179 | const char *zDflt /* Default value for the parameter */ ){ cookie_readwrite(zQP, zPName, zDflt, COOKIE_READ|COOKIE_WRITE); } /* Update the user preferences cookie, if necessary, and shut down ** this module. The cookie is only emitted if its value has actually | | > > > > > > > > > > | | 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 | const char *zDflt /* Default value for the parameter */ ){ cookie_readwrite(zQP, zPName, zDflt, COOKIE_READ|COOKIE_WRITE); } /* Update the user preferences cookie, if necessary, and shut down ** this module. The cookie is only emitted if its value has actually ** changed since the request started and the "udc" (Update Display ** Cookie) URL argument was provided. ** ** Historical note: from 2021-03-02 [71a2d68a7a113e7c] until ** 2023-01-16, the udc was not observed (it had been prior to that), ** and that led to the unfortunate side effect that a timeline link ** from the /reports page would end up persistently setting a user's ** timeline length preference to the number of items in that ** report. In a /chat discussion it was agreed that updating the ** cookie requires explicit opt-in via the udc argument or ?skin=..., ** which implies udc. */ void cookie_render(void){ if( cookies.bChanged && P("udc")!=0 ){ Blob new; int i; blob_init(&new, 0, 0); for(i=0;i<cookies.nParam;i++){ if( i>0 ) blob_append(&new, ",", 1); blob_appendf(&new, "%s=%T", cookies.aParam[i].zPName, cookies.aParam[i].zPValue); |
︙ | ︙ |
Changes to src/info.c.
︙ | ︙ | |||
879 880 881 882 883 884 885 | "<div class=\"section accordion\">References</div>\n"); @ <div class="section accordion">Context</div><div class="accordion_panel"> render_checkin_context(rid, 0, 0, 0); @ </div><div class="section accordion">Changes</div> @ <div class="accordion_panel"> @ <div class="sectionmenu"> pCfg = construct_diff_flags(diffType, &DCfg); | | | 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 | "<div class=\"section accordion\">References</div>\n"); @ <div class="section accordion">Context</div><div class="accordion_panel"> render_checkin_context(rid, 0, 0, 0); @ </div><div class="section accordion">Changes</div> @ <div class="accordion_panel"> @ <div class="sectionmenu"> pCfg = construct_diff_flags(diffType, &DCfg); DCfg.pRe = pRe; zW = (DCfg.diffFlags&DIFF_IGNORE_ALLWS)?"&w":""; if( diffType!=0 ){ @ %z(chref("button","%R/%s/%T?diff=0",zPageHide,zName))\ @ Hide Diffs</a> } if( diffType!=1 ){ @ %z(chref("button","%R/%s/%T?diff=1%s",zPage,zName,zW))\ |
︙ | ︙ | |||
933 934 935 936 937 938 939 | ); while( db_step(&q3)==SQLITE_ROW ){ const char *zName = db_column_text(&q3,0); int mperm = db_column_int(&q3, 1); const char *zOld = db_column_text(&q3,2); const char *zNew = db_column_text(&q3,3); const char *zOldName = db_column_text(&q3, 4); | | | 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 | ); while( db_step(&q3)==SQLITE_ROW ){ const char *zName = db_column_text(&q3,0); int mperm = db_column_int(&q3, 1); const char *zOld = db_column_text(&q3,2); const char *zNew = db_column_text(&q3,3); const char *zOldName = db_column_text(&q3, 4); append_file_change_line(zUuid, zName, zOld, zNew, zOldName, pCfg,mperm); } db_finalize(&q3); @ </div> append_diff_javascript(diffType); style_finish_page(); } |
︙ | ︙ |
Changes to src/main.c.
︙ | ︙ | |||
1462 1463 1464 1465 1466 1467 1468 | } /* ** Send an HTTP redirect back to the designated Index Page. */ NORETURN void fossil_redirect_home(void){ /* In order for ?skin=... to work when visiting the site from | | | 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 | } /* ** Send an HTTP redirect back to the designated Index Page. */ NORETURN void fossil_redirect_home(void){ /* In order for ?skin=... to work when visiting the site from ** a typical external link, we have to process it here, as ** that parameter gets lost during the redirect. We "could" ** pass the whole query string along instead, but that seems ** unnecessary. */ if(cgi_setup_query_string()>1){ cookie_render(); } cgi_redirectf("%R%s", db_get("index-page", "/index")); |
︙ | ︙ |
Changes to src/style.c.
︙ | ︙ | |||
1136 1137 1138 1139 1140 1141 1142 | /* Add document end mark if it was not in the footer */ if( sqlite3_strlike("%</body>%", zFooter, 0)!=0 ){ style_load_all_js_files(); @ </body> @ </html> } | | < < | 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 | /* Add document end mark if it was not in the footer */ if( sqlite3_strlike("%</body>%", zFooter, 0)!=0 ){ style_load_all_js_files(); @ </body> @ </html> } /* Update the user display prefs cookie if it was modified */ cookie_render(); } /* ** Begin a side-box on the right-hand side of a page. The title and ** the width of the box are given as arguments. The width is usually ** a percentage of total screen width. |
︙ | ︙ |