Fossil

Check-in [a9995c56]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Resolved, it seems, skin cookie/query param/--skin flag priority bug which allowed an empty skin= query param to take effect even when --skin was used. Reported in forum post 745cbb55268aff37.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: a9995c561be17dda11f3e6410b1375d9b57ffd2fca02e5befd469cadec8b90dc
User & Date: stephan 2021-08-18 21:37:30
Context
2021-08-19
10:37
URL fix addressing a report on the forum. ... (check-in: 0da45710 user: wyoung tags: trunk)
2021-08-18
21:37
Resolved, it seems, skin cookie/query param/--skin flag priority bug which allowed an empty skin= query param to take effect even when --skin was used. Reported in forum post 745cbb55268aff37. ... (check-in: a9995c56 user: stephan tags: trunk)
19:13
attachment_list(), used by wiki, tech-note, and ticket attachment lists, now includes a download link which attempts to download using the file's name instead of artifact ID. Discussed in forum post 6566f665a3685c4f. ... (check-in: 648bb4c1 user: stephan tags: trunk)
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to src/skins.c.

141
142
143
144
145
146
147

148
149
150
151
152
153
154
** be used (rank 3, above), then returns 0.
*/
char *skin_use_alternative(const char *zName, int rank){
  static int currentRank = 5;
  int i;
  Blob err = BLOB_INITIALIZER;
  if(rank > currentRank) return 0;

  if( zName && 1==rank && strchr(zName, '/')!=0 ){
    zAltSkinDir = fossil_strdup(zName);
    return 0;
  }
  if( zName && sqlite3_strglob("draft[1-9]", zName)==0 ){
    skin_use_draft(zName[5] - '0');
    return 0;







>







141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
** be used (rank 3, above), then returns 0.
*/
char *skin_use_alternative(const char *zName, int rank){
  static int currentRank = 5;
  int i;
  Blob err = BLOB_INITIALIZER;
  if(rank > currentRank) return 0;
  currentRank = rank;
  if( zName && 1==rank && strchr(zName, '/')!=0 ){
    zAltSkinDir = fossil_strdup(zName);
    return 0;
  }
  if( zName && sqlite3_strglob("draft[1-9]", zName)==0 ){
    skin_use_draft(zName[5] - '0');
    return 0;