Ticket Hash: | 5ff2043c966820498ce41c0dd425b4b2155fa025 | |||
Title: | Invalid xhtml markup generated (with patch) | |||
Status: | Fixed | Type: | Code_Defect | |
Severity: | Important | Priority: | ||
Subsystem: | Resolution: | Fixed | ||
Last Modified: | 2012-11-08 13:47:11 | |||
Version Found In: | 2011-04-19 20:30:31 085b6a1bbb | |||
Description: | ||||
While most of the generated fossil output is valid xhtml, there are still several places that aren't.
These include not using & instead of a plain & when generating URLs in href attributes, using <br> and <hr> instead of <br /> and <hr />, using instead of   and finally the occasional <img> instead of <img />. The attached patch corrects these issues so that fossil can return valid application/xhtml+xml content. dmitry added on 2011-09-08 23:11:38 UTC: jan.nijtmans added on 2012-11-06 09:05:14 UTC: Wouldn't it be better to modify style_submenu_element() such that it escapes all &'s to &? Then those (minor) html5 violations are fixed all at once. jan.nijtmans added on 2012-11-08 09:51:47 UTC: I put many pages, such as "timeline" to the validator.w3.org, and it reduced dramatically the number of errors. The current "timeline" page dropped from 85 to only 4 errors. That's better than changing many &'s to &'s in the source code, as this patch does. Changing only the href() and style_submenu_element() functions has much more effect. jan.nijtmans added on 2012-11-08 10:31:49 UTC: Note that xhtml errors can result in real bugs. For example have a look at the report list: http://www.fossil-scm.org/fossil/reportlist When logged in, this page contains links [copy] after each report. This link works fine on Firefox, but it doesn't work on Internet Explorer, and this time IE is not to blame ;-) |
Attachments:
- markuppatch.diff.txt [download] added by anonymous on 2011-04-22 03:06:40. [details]