Fossil

Changes On Branch signed-chars
Login

Changes On Branch signed-chars

Hide Diff Patch Unified Diff

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Changes In Branch signed-chars Excluding Merge-Ins

This is equivalent to a diff from 22ee43db to c42dee86

2024-01-03
14:43
Ensure chars are signed when depending on the signedness. ... (check-in: b7c7c209 user: preben tags: trunk)
2023-11-28
22:05
Tiny documentation fix: an extra space before argument to the '--base-rcvid' hook test option made the argument appear on the line describing the option. ... (check-in: cb283ca5 user: km tags: trunk)
19:31
Use signed char for two json timeline functions that may return -1. ... (Closed-Leaf check-in: c42dee86 user: preben tags: signed-chars)
14:58
Fix sort order in json_page_finfo() on systems where char is unsigned. ... (check-in: fd288be3 user: preben tags: signed-chars)
2023-11-27
10:28
Fix typos in unvers.wiki. ... (check-in: 22ee43db user: danield tags: trunk)
2023-11-25
15:56
Remove description of unsupported option that was removed with [298ccff06c487d035a7] from "fossil all rebuild" command. No change in functionality. ... (check-in: 33fa9155 user: andybradford tags: trunk)

Changes to src/json_finfo.c.

︙︙
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48

  Blob sql = empty_blob;
  Stmt q = empty_Stmt;
  char const * zAfter = NULL;
  char const * zBefore = NULL;
  int limit = -1;
  int currentRow = 0;
  char const * zCheckin = NULL;
  char sort = -1;
  if(!g.perm.Read){
    json_set_err(FSL_JSON_E_DENIED,"Requires 'o' privileges.");
    return NULL;
  }
  json_warn( FSL_JSON_W_UNKNOWN, "Achtung: the output of the finfo command is up for change.");

  /* For the "name" argument we have to jump through some hoops to make sure that we don't








|








34
35
36
37
38
39
40
41
42
43
44
45
46
47
48

  Blob sql = empty_blob;
  Stmt q = empty_Stmt;
  char const * zAfter = NULL;
  char const * zBefore = NULL;
  int limit = -1;
  int currentRow = 0;
  char const * zCheckin = NULL;
  signed char sort = -1;
  if(!g.perm.Read){
    json_set_err(FSL_JSON_E_DENIED,"Requires 'o' privileges.");
    return NULL;
  }
  json_warn( FSL_JSON_W_UNKNOWN, "Achtung: the output of the finfo command is up for change.");

  /* For the "name" argument we have to jump through some hoops to make sure that we don't
︙︙

Changes to src/json_timeline.c.

︙︙
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156

**
** If payload is not NULL then on success its "tag" or "branch"
** property is set to the tag/branch name found in the request.
**
** Only one of "tag" or "branch" modes will work at a time, and if
** both are specified, which one takes precedence is unspecified.
*/
static char json_timeline_add_tag_branch_clause(Blob *pSql,
                                                cson_object * pPayload){
  char const * zTag = NULL;
  char const * zBranch = NULL;
  char const * zMiOnly = NULL;
  char const * zUnhide = NULL;
  int tagid = 0;
  if(! g.perm.Read ){
    return 0;








|
|








141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156

**
** If payload is not NULL then on success its "tag" or "branch"
** property is set to the tag/branch name found in the request.
**
** Only one of "tag" or "branch" modes will work at a time, and if
** both are specified, which one takes precedence is unspecified.
*/
static signed char json_timeline_add_tag_branch_clause(Blob *pSql,
                                                       cson_object * pPayload){
  char const * zTag = NULL;
  char const * zBranch = NULL;
  char const * zMiOnly = NULL;
  char const * zUnhide = NULL;
  int tagid = 0;
  if(! g.perm.Read ){
    return 0;
︙︙
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232

** of the "after" ("a") or "before" ("b") environment parameters.
** This function gives "after" precedence over "before", and only
** applies one of them.
**
** Returns -1 if it adds a "before" clause, 1 if it adds
** an "after" clause, and 0 if adds only an order-by clause.
*/
static char json_timeline_add_time_clause(Blob *pSql){
  char const * zAfter = NULL;
  char const * zBefore = NULL;
  int rc = 0;
  zAfter = json_find_option_cstr("after",NULL,"a");
  zBefore = zAfter ? NULL : json_find_option_cstr("before",NULL,"b");

  if(zAfter&&*zAfter){








|








218
219
220
221
222
223
224
225
226
227
228
229
230
231
232

** of the "after" ("a") or "before" ("b") environment parameters.
** This function gives "after" precedence over "before", and only
** applies one of them.
**
** Returns -1 if it adds a "before" clause, 1 if it adds
** an "after" clause, and 0 if adds only an order-by clause.
*/
static signed char json_timeline_add_time_clause(Blob *pSql){
  char const * zAfter = NULL;
  char const * zBefore = NULL;
  int rc = 0;
  zAfter = json_find_option_cstr("after",NULL,"a");
  zBefore = zAfter ? NULL : json_find_option_cstr("before",NULL,"b");

  if(zAfter&&*zAfter){
︙︙