Fossil

Check-in [8184f39d]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fix crash in /reports page, when compiling with recent gcc. (this is NOT an -O2 optimization bug!)
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: 8184f39d803f9ad6c8f8880996c6a9f3557f1d5d
User & Date: jan.nijtmans 2015-06-02 08:17:51
References
2015-06-02
09:17
Cherrypick [8184f39d803f9ad6|8184f39d]: Fix crash in /reports page, when compiling with recent gcc. (this is NOT an -O2 optimization bug!) Closed-Leaf check-in: 08709aa7 user: jan.nijtmans tags: branch-1.33
Context
2015-06-02
09:47
Slight optimization: Make two tables "static" that can be. check-in: 4440dae2 user: jan.nijtmans tags: trunk
09:17
Cherrypick [8184f39d803f9ad6|8184f39d]: Fix crash in /reports page, when compiling with recent gcc. (this is NOT an -O2 optimization bug!) Closed-Leaf check-in: 08709aa7 user: jan.nijtmans tags: branch-1.33
08:17
Fix crash in /reports page, when compiling with recent gcc. (this is NOT an -O2 optimization bug!) check-in: 8184f39d user: jan.nijtmans tags: trunk
2015-05-31
11:19
Make azType in statrep.c a const table (which it actually is ...) check-in: b43681dc user: jan.nijtmans tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to src/statrep.c.

670
671
672
673
674
675
676

677
678
679
680
681
682
683
...
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
*/
void stats_report_page(){
  HQuery url;                        /* URL for various branch links */
  const char *zView = P("view");     /* Which view/report to show. */
  int eType = RPT_NONE;              /* Numeric code for view/report to show */
  int i;                             /* Loop counter */
  const char *zUserName;             /* Name of user */

  const struct {
    const char *zName;  /* Name of view= screen type */
    const char *zVal;   /* Value of view= query parameter */
    int eType;          /* Corresponding RPT_* define */
  } aViewType[] = {
     {  "File Changes","byfile",    RPT_BYFILE    },
     {  "By Month",    "bymonth",   RPT_BYMONTH   },
................................................................................
      break;
    }
  }
  url_initialize(&url, "reports");
  cgi_query_parameters_to_url(&url);
  if( eType!=RPT_NONE ){
    int nView = 0;                     /* Slots used in azView[] */
    const char *azView[16];            /* Drop-down menu of view types */
    for(i=0; i<ArraySize(aViewType); i++){
      azView[nView++] = aViewType[i].zVal;
      azView[nView++] = aViewType[i].zName;
    }
    if( eType!=RPT_BYFILE ){
      style_submenu_multichoice("type", ArraySize(azType)/2, azType, 0);
    }







>







 







<







670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
...
711
712
713
714
715
716
717

718
719
720
721
722
723
724
*/
void stats_report_page(){
  HQuery url;                        /* URL for various branch links */
  const char *zView = P("view");     /* Which view/report to show. */
  int eType = RPT_NONE;              /* Numeric code for view/report to show */
  int i;                             /* Loop counter */
  const char *zUserName;             /* Name of user */
  const char *azView[16];            /* Drop-down menu of view types */
  const struct {
    const char *zName;  /* Name of view= screen type */
    const char *zVal;   /* Value of view= query parameter */
    int eType;          /* Corresponding RPT_* define */
  } aViewType[] = {
     {  "File Changes","byfile",    RPT_BYFILE    },
     {  "By Month",    "bymonth",   RPT_BYMONTH   },
................................................................................
      break;
    }
  }
  url_initialize(&url, "reports");
  cgi_query_parameters_to_url(&url);
  if( eType!=RPT_NONE ){
    int nView = 0;                     /* Slots used in azView[] */

    for(i=0; i<ArraySize(aViewType); i++){
      azView[nView++] = aViewType[i].zVal;
      azView[nView++] = aViewType[i].zName;
    }
    if( eType!=RPT_BYFILE ){
      style_submenu_multichoice("type", ArraySize(azType)/2, azType, 0);
    }