Shortly after submitting my most recent post, I opened a different browser that had no login cookie for this repo and saw that it was already visible. Is that the intent? Since the post didn't (at that time) show an Edit button, my understanding is that it hadn't yet been approved by the moderator.

Unless such posts are hidden from other users until they're approved, don't we still have a potential way for spammers to shove their...um, content in front of us?

There is such a setting — capability 4 in Admin → Users, "WriteTrusted Forum" — but I'm pretty sure I don't have it.

I'll add it to my ever-growing list of things to address.

I've checked in a fix for this as branch hide-post-if-needmod for your approval. It works here in tests, but it feels like the sort of thing that should pass under the eyes of someone more experienced with the code base before going to trunk.

I'm concerned about a few things:

1. It makes the main forum page heavier, since it involves nested queries now. Does it matter? Can you rework the SQL to pull it all in a single pass instead?

2. Does it work for anonymous users? (Didn't test.)

You might want to move the fpid column to the front of the query. I put it at the end just to keep the size of the diff small.

In the latest trunk version of Fossil (now up on the website) the text of forum posts that are awaiting moderation is omitted for readers who do not have moderator privilege and who are not the original author of the post. Instead, the post simply says "Awaiting Moderator Approval".

Similarly, the /forum page omits all unmoderated posts from consideration when it is displaying the various threads, unless the viewer has forum moderator privileges. Unlike the display of individual posts, on the /forum page, even posts from the same user are excluded if they are unmoderated.